linux-kernel - Re: [PATCH -next v4 1/2] x86/boot: Remove unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Oct 2022 14:22:18 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Li Zetao <lizetao1@...wei.com>
Cc:     keescook@...omium.org, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org,
        hpa@...or.com, kirill.shutemov@...ux.intel.com,
        tony.luck@...el.com, masahiroy@...nel.org, michael.roth@....com,
        sathyanarayanan.kuppuswamy@...ux.intel.com, nathan@...nel.org,
        brijesh.singh@....com, peterz@...radead.org,
        venu.busireddy@...cle.com, linux-kernel@...r.kernel.org,
        akpm@...ux-foundation.org
Subject: Re: [PATCH -next v4 1/2] x86/boot: Remove unused variables

On Mon, Oct 10, 2022 at 6:32 PM Li Zetao <lizetao1@...wei.com> wrote:
>
> diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c
> index c93930d5ccbd..b9451761a69a 100644
> --- a/arch/x86/boot/compressed/sev.c
> +++ b/arch/x86/boot/compressed/sev.c
> @@ -253,7 +253,6 @@ void do_boot_stage2_vc(struct pt_regs *regs, unsigned long exit_code)
>  static void enforce_vmpl0(void)
>  {
>         u64 attrs;
> -       int err;

Just a thought but you could initialize attrs now on the same line.

I also ended up testing the whole series, so:

Tested-by: Nick Desaulniers <ndesaulniers@...gle.com>
-- 
Thanks,
~Nick Desaulniers