linux-kernel - Re: [PATCH 08/19] perf stat: Allocate evsel->stats->aggr properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7cjed=JxNMruxqnp=E36wiHLz6-GcybdewPm1PbKpWJNnA@mail.gmail.com>
Date:   Tue, 11 Oct 2022 16:38:49 -0700
From:   Namhyung Kim <namhyung@...nel.org>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>, Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        linux-perf-users <linux-perf-users@...r.kernel.org>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Leo Yan <leo.yan@...aro.org>, Andi Kleen <ak@...ux.intel.com>,
        Athira Rajeev <atrajeev@...ux.vnet.ibm.com>,
        James Clark <james.clark@....com>,
        Xing Zhengjun <zhengjun.xing@...ux.intel.com>
Subject: Re: [PATCH 08/19] perf stat: Allocate evsel->stats->aggr properly

On Mon, Oct 10, 2022 at 4:03 PM Ian Rogers <irogers@...gle.com> wrote:
>
> On Sun, Oct 9, 2022 at 10:36 PM Namhyung Kim <namhyung@...nel.org> wrote:
> >
> > The perf_stat_config.aggr_map should have a correct size of the
> > aggregation map.  Use it to allocate aggr_counts.
> >
> > Also AGGR_NONE with per-core events can be tricky because it doesn't
> > aggreate basically but it needs to do so for per-core events only.
>
> nit: s/aggreate/aggregate/
>
> > So only per-core evsels will have stats->aggr data.
> >
> > Note that other caller of evlist__alloc_stat() might not have
> > stat_config or aggr_map.
> >
> > Signed-off-by: Namhyung Kim <namhyung@...nel.org>
>
> Acked-by: Ian Rogers <irogers@...gle.com>
>
> nit: Below there are use of constants true, false and NULL, it would
> be nice to use the /*argument_name=*/... style parameter passing to be
> clearer on what the parameter means.

Sounds good.  Will add.

Thanks,
Namhyung