[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y0YAaXPzuSmSKwiG@relinquished.localdomain>
Date: Tue, 11 Oct 2022 16:46:49 -0700
From: Omar Sandoval <osandov@...ndov.com>
To: Sasha Levin <sashal@...nel.org>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
Omar Sandoval <osandov@...com>,
Filipe Manana <fdmanana@...e.com>,
David Sterba <dsterba@...e.com>, clm@...com,
josef@...icpanda.com, linux-btrfs@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.0 33/46] btrfs: get rid of block group caching
progress logic
On Tue, Oct 11, 2022 at 10:50:01AM -0400, Sasha Levin wrote:
> From: Omar Sandoval <osandov@...com>
>
> [ Upstream commit 48ff70830bec1ccc714f4e31059df737f17ec909 ]
>
> struct btrfs_caching_ctl::progress and struct
> btrfs_block_group::last_byte_to_unpin were previously needed to ensure
> that unpin_extent_range() didn't return a range to the free space cache
> before the caching thread had a chance to cache that range. However, the
> commit "btrfs: fix space cache corruption and potential double
> allocations" made it so that we always synchronously cache the block
> group at the time that we pin the extent, so this machinery is no longer
> necessary.
>
> Reviewed-by: Filipe Manana <fdmanana@...e.com>
> Signed-off-by: Omar Sandoval <osandov@...com>
> Signed-off-by: David Sterba <dsterba@...e.com>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
> fs/btrfs/block-group.c | 13 ------------
> fs/btrfs/block-group.h | 2 --
> fs/btrfs/extent-tree.c | 9 ++-------
> fs/btrfs/free-space-tree.c | 8 --------
> fs/btrfs/transaction.c | 41 --------------------------------------
> fs/btrfs/zoned.c | 1 -
> 6 files changed, 2 insertions(+), 72 deletions(-)
Hi, Sasha,
This commit is a cleanup. Please drop it from 6.0 and 5.19.
Thanks,
Omar
Powered by blists - more mailing lists