linux-kernel - drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c:521 amdgpu_gfx_rlc_init_microcode() warn: always true condition '(version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202210111119.ZF7klPJR-lkp@intel.com>
Date:   Tue, 11 Oct 2022 11:27:53 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hawking Zhang <Hawking.Zhang@....com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Alex Deucher <alexander.deucher@....com>
Subject: drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c:521
 amdgpu_gfx_rlc_init_microcode() warn: always true condition '(version_minor
 >= 0) => (0-u16max >= 0)'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   e2302539dd4f1c62d96651c07ddb05aa2461d29c
commit: 04fa38cce6e02be4362cd889780d58ec275c4d26 drm/amdgpu: add helper to init rlc firmware
date:   10 days ago
config: ia64-randconfig-m031-20221010
compiler: ia64-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

smatch warnings:
drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c:521 amdgpu_gfx_rlc_init_microcode() warn: always true condition '(version_minor >= 0) => (0-u16max >= 0)'

vim +521 drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.c

   504	
   505	int amdgpu_gfx_rlc_init_microcode(struct amdgpu_device *adev,
   506					  uint16_t version_major,
   507					  uint16_t version_minor)
   508	{
   509		int err;
   510	
   511		if (version_major < 2) {
   512			/* only support rlc_hdr v2.x and onwards */
   513			dev_err(adev->dev, "unsupported rlc fw hdr\n");
   514			return -EINVAL;
   515		}
   516	
   517		/* is_rlc_v2_1 is still used in APU code path */
   518		if (version_major == 2 && version_minor == 1)
   519			adev->gfx.rlc.is_rlc_v2_1 = true;
   520	
 > 521		if (version_minor >= 0) {

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (157563 bytes)