[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <166546305360.5539.195125262037434814.kvalo@kernel.org>
Date: Tue, 11 Oct 2022 04:37:35 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Fedor Pchelkin <pchelkin@...ras.ru>
Cc: Toke Høiland-Jørgensen <toke@...e.dk>,
Fedor Pchelkin <pchelkin@...ras.ru>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Brooke Basile <brookebasile@...il.com>,
linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
Alexey Khoroshilov <khoroshilov@...ras.ru>
Subject: Re: [PATCH] ath9k: hif_usb: fix memory leak of urbs in
ath9k_hif_usb_dealloc_tx_urbs()
Fedor Pchelkin <pchelkin@...ras.ru> wrote:
> Syzkaller reports a long-known leak of urbs in
> ath9k_hif_usb_dealloc_tx_urbs().
>
> The cause of the leak is that usb_get_urb() is called but usb_free_urb()
> (or usb_put_urb()) is not called inside usb_kill_urb() as urb->dev or
> urb->ep fields have not been initialized and usb_kill_urb() returns
> immediately.
>
> The patch removes trying to kill urbs located in hif_dev->tx.tx_buf
> because hif_dev->tx.tx_buf is not supposed to contain urbs which are in
> pending state (the pending urbs are stored in hif_dev->tx.tx_pending).
> The tx.tx_lock is acquired so there should not be any changes in the list.
>
> Found by Linux Verification Center (linuxtesting.org) with Syzkaller.
>
> Fixes: 03fb92a432ea ("ath9k: hif_usb: fix race condition between usb_get_urb() and usb_kill_anchored_urbs()")
> Signed-off-by: Fedor Pchelkin <pchelkin@...ras.ru>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>
> Acked-by: Toke Høiland-Jørgensen <toke@...e.dk>
> Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com>
Patch applied to ath-next branch of ath.git, thanks.
c2a94de38c74 wifi: ath9k: hif_usb: fix memory leak of urbs in ath9k_hif_usb_dealloc_tx_urbs()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220725151359.283704-1-pchelkin@ispras.ru/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists