linux-kernel - Re: [PATCH] USB: make devnode() callback in usb_class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221011004550.46e068f5@niphredil.zaitcev.lan>
Date:   Tue, 11 Oct 2022 00:45:50 -0500
From:   Pete Zaitcev <zaitcev@...hat.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Juergen Stuber <starblue@...rs.sourceforge.net>,
        Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH] USB: make devnode() callback in usb_class_driver take a
 const *

On Sat,  1 Oct 2022 18:51:28 +0200
Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:

> +++ b/drivers/usb/class/usblp.c
> @@ -1090,7 +1090,7 @@ static const struct file_operations usblp_fops = {
> -static char *usblp_devnode(struct device *dev, umode_t *mode)
> +static char *usblp_devnode(const struct device *dev, umode_t *mode)
>  {
>  	return kasprintf(GFP_KERNEL, "usb/%s", dev_name(dev));
>  }

Seems obvious.

Acked-by: Pete Zaitcev <zaitcev@...hat.com>

-- P