[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <f78f1d8a-096b-60ad-e0de-266b63de8ffd@topic.nl>
Date: Tue, 11 Oct 2022 08:20:38 +0200
From: Mike Looijmans <mike.looijmans@...ic.nl>
To: linux-leds@...r.kernel.org
CC: Pavel Machek <pavel@....cz>, linux-kernel@...r.kernel.org,
p.meerwald@...-electronic.com
Subject: Re: [PATCH 1/2] leds: pca963x: Add support for PCA962x chips
Just a gentle "ping", haven't seen any feedback for quite some time. Any
issues, comments?
Met vriendelijke groet / kind regards,
Mike Looijmans
System Expert
TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands
T: +31 (0) 499 33 69 69
E: mike.looijmans@...icproducts.com
W: www.topic.nl
Please consider the environment before printing this e-mail
On 22-08-2022 08:18, Mike Looijmans wrote:
> The PCA962x family shares the same I2C register layout and functionality.
> This adds support for the following chips:
> PCA9623 4-channel
> PCA9624 8-channel
> PCA9622 16-channel
> PCA9626 24-channel
>
> Tested only the PCA9624. Other devices based on datasheet information.
>
> Signed-off-by: Mike Looijmans <mike.looijmans@...ic.nl>
> ---
>
> drivers/leds/Kconfig | 8 ++++----
> drivers/leds/leds-pca963x.c | 36 ++++++++++++++++++++++++++++++++++++
> 2 files changed, 40 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index 499d0f215a8b..9a99190c13af 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -497,13 +497,13 @@ config LEDS_PCA955X_GPIO
>
>
> config LEDS_PCA963X
> - tristate "LED support for PCA963x I2C chip"
> + tristate "LED support for PCA962x and PCA963x I2C chips"
> depends on LEDS_CLASS
> depends on I2C
> help
> - This option enables support for LEDs connected to the PCA963x
> - LED driver chip accessed via the I2C bus. Supported
> - devices include PCA9633 and PCA9634
> + This option enables support for LEDs connected to the PCA96xx
> + LED driver chip accessed via the I2C bus. Supported devices:
> + PCA9622, PCA9623, PCA9624, PCA9626, PCA9633, PCA9634, PCA9635.
>
> config LEDS_WM831X_STATUS
> tristate "LED support for status LEDs on WM831x PMICs"
> diff --git a/drivers/leds/leds-pca963x.c b/drivers/leds/leds-pca963x.c
> index 00aecd67e348..4d589624d192 100644
> --- a/drivers/leds/leds-pca963x.c
> +++ b/drivers/leds/leds-pca963x.c
> @@ -48,6 +48,10 @@
> #define PCA963X_PWM_BASE 0x02
>
> enum pca963x_type {
> + pca9622,
> + pca9623,
> + pca9624,
> + pca9626,
> pca9633,
> pca9634,
> pca9635,
> @@ -62,6 +66,30 @@ struct pca963x_chipdef {
> };
>
> static struct pca963x_chipdef pca963x_chipdefs[] = {
> + [pca9622] = {
> + .grppwm = 0x12,
> + .grpfreq = 0x13,
> + .ledout_base = 0x14,
> + .n_leds = 16,
> + },
> + [pca9623] = {
> + .grppwm = 0x6,
> + .grpfreq = 0x7,
> + .ledout_base = 0x8,
> + .n_leds = 4,
> + },
> + [pca9624] = {
> + .grppwm = 0xa,
> + .grpfreq = 0xb,
> + .ledout_base = 0xc,
> + .n_leds = 8,
> + },
> + [pca9626] = {
> + .grppwm = 0x1a,
> + .grpfreq = 0x1b,
> + .ledout_base = 0x1d,
> + .n_leds = 24,
> + },
> [pca9633] = {
> .grppwm = 0x6,
> .grpfreq = 0x7,
> @@ -87,6 +115,10 @@ static struct pca963x_chipdef pca963x_chipdefs[] = {
> #define PCA963X_BLINK_PERIOD_MAX 10667
>
> static const struct i2c_device_id pca963x_id[] = {
> + { "pca9622", pca9622 },
> + { "pca9623", pca9623 },
> + { "pca9624", pca9624 },
> + { "pca9626", pca9626 },
> { "pca9632", pca9633 },
> { "pca9633", pca9633 },
> { "pca9634", pca9634 },
> @@ -363,6 +395,10 @@ static int pca963x_register_leds(struct i2c_client *client,
> }
>
> static const struct of_device_id of_pca963x_match[] = {
> + { .compatible = "nxp,pca9622", },
> + { .compatible = "nxp,pca9623", },
> + { .compatible = "nxp,pca9624", },
> + { .compatible = "nxp,pca9626", },
> { .compatible = "nxp,pca9632", },
> { .compatible = "nxp,pca9633", },
> { .compatible = "nxp,pca9634", },
--
Mike Looijmans
Powered by blists - more mailing lists