linux-kernel - Re: [PATCH v3] soc: imx: imx8m-blk-ctrl: Defer probe if 'bus' genpd is not yet ready

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bdfacbcc-c4e2-e1f2-1b83-082306170952@collabora.com>
Date:   Tue, 11 Oct 2022 08:38:52 +0200
From:   Benjamin Gaignard <benjamin.gaignard@...labora.com>
To:     shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, linux-imx@....com
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel@...labora.com
Subject: Re: [PATCH v3] soc: imx: imx8m-blk-ctrl: Defer probe if 'bus' genpd
 is not yet ready


Le 19/09/2022 à 14:13, Benjamin Gaignard a écrit :
> Depending of the boot sequence 'bus' genpd could be probed after imx8m-blk-ctrl
> which led driver probe to fail. Change the returned error to allow
> to defer the probe in this case.

Gentle reminder about this patch.

Thanks,
Benjamin

>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...labora.com>
> ---
> v3:
> - only return -EPROBE_DEFER if 'bus' device hasn't be found.
>
> v2:
> - keep dev_err_probe only change the return value.
>
>   drivers/soc/imx/imx8m-blk-ctrl.c | 11 ++++++++---
>   1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c
> index dff7529268e4..1c195e9e8895 100644
> --- a/drivers/soc/imx/imx8m-blk-ctrl.c
> +++ b/drivers/soc/imx/imx8m-blk-ctrl.c
> @@ -214,9 +214,14 @@ static int imx8m_blk_ctrl_probe(struct platform_device *pdev)
>   		return -ENOMEM;
>   
>   	bc->bus_power_dev = genpd_dev_pm_attach_by_name(dev, "bus");
> -	if (IS_ERR(bc->bus_power_dev))
> -		return dev_err_probe(dev, PTR_ERR(bc->bus_power_dev),
> -				     "failed to attach power domain \"bus\"\n");
> +	if (IS_ERR(bc->bus_power_dev)) {
> +		if (PTR_ERR(bc->bus_power_dev) == -ENODEV)
> +			return dev_err_probe(dev, -EPROBE_DEFER,
> +					     "failed to attach power domain \"bus\"\n");
> +		else
> +			return dev_err_probe(dev, PTR_ERR(bc->bus_power_dev),
> +					     "failed to attach power domain \"bus\"\n");
> +	}
>   
>   	for (i = 0; i < bc_data->num_domains; i++) {
>   		const struct imx8m_blk_ctrl_domain_data *data = &bc_data->domains[i];