linux-kernel - Re: [PATCH] mmc: sdhci-sprd: Fix minimum clock limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Oct 2022 09:45:13 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Wenchao Chen <wenchao.chen666@...il.com>, ulf.hansson@...aro.org,
        orsonzhai@...il.com, baolin.wang@...ux.alibaba.com,
        zhang.lyra@...il.com
Cc:     linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        megoo.tang@...il.com, lzx.stg@...il.com
Subject: Re: [PATCH] mmc: sdhci-sprd: Fix minimum clock limit

On 11/10/22 09:30, Wenchao Chen wrote:
> From: Wenchao Chen <wenchao.chen@...soc.com>
> 
> The minimum clock supported by SPRD Host is 100000.

Commit messages are better if they say why a change
is being made.

This begs the question, was there a problem with 400 kHz?
Are there cases that benefit from this change?
Should it have a fixes tag,cc stable?

> 
> Signed-off-by: Wenchao Chen <wenchao.chen@...soc.com>
> ---
>  drivers/mmc/host/sdhci-sprd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c
> index 46c55ab4884c..b92a408f138d 100644
> --- a/drivers/mmc/host/sdhci-sprd.c
> +++ b/drivers/mmc/host/sdhci-sprd.c
> @@ -309,7 +309,7 @@ static unsigned int sdhci_sprd_get_max_clock(struct sdhci_host *host)
>  
>  static unsigned int sdhci_sprd_get_min_clock(struct sdhci_host *host)
>  {
> -	return 400000;
> +	return 100000;
>  }
>  
>  static void sdhci_sprd_set_uhs_signaling(struct sdhci_host *host,