linux-kernel - Re: [PATCH -next] selftests/memory-hotplug: Remove the redundant warning information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eb839bff-90ff-adfe-c463-a20fdfa86b0e@redhat.com>
Date:   Tue, 11 Oct 2022 09:31:16 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Zhao Gongyi <zhaogongyi@...wei.com>, linux-mm@...ck.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     osalvador@...e.de, shuah@...nel.org
Subject: Re: [PATCH -next] selftests/memory-hotplug: Remove the redundant
 warning information

On 11.10.22 03:39, Zhao Gongyi wrote:
> Remove the redundant warning information of online_all_offline_memory()
> since there is a warning in online_memory_expect_success().
> 
> Signed-off-by: Zhao Gongyi <zhaogongyi@...wei.com>
> ---
>   tools/testing/selftests/memory-hotplug/mem-on-off-test.sh | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> index 74ee5067a8ce..611be86eaf3d 100755
> --- a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> +++ b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> @@ -138,7 +138,6 @@ online_all_offline_memory()
>   {
>   	for memory in `hotpluggable_offline_memory`; do
>   		if ! online_memory_expect_success $memory; then
> -			echo "$FUNCNAME $memory: unexpected fail" >&2
>   			retval=1
>   		fi
>   	done
> --
> 2.17.1
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb