linux-kernel - [PATCH] speakup: remove usage of non-standard u

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b7e4894-deec-39ba-bb7c-3c6d6427fa1d@yuka.dev>
Date:   Tue, 11 Oct 2022 02:17:43 +0200
From:   Yureka <yuka@...a.dev>
To:     samuel.thibault@...-lyon.org
Cc:     w.d.hubbs@...il.com, chris@...-brannons.com,
        chris@...-brannons.com, gregkh@...uxfoundation.org,
        speakup@...ux-speakup.org, linux-kernel@...r.kernel.org
Subject: [PATCH] speakup: remove usage of non-standard u_char

From: Yureka Lilian <yuka@...a.dev>

This code is included in the build tools makemapdata and genmap, and it
expects that libc exposes a definition of u_char. But u_char is not
defined in either C or POSIX standards, and some systems don't have it.
Namely this breaks the build on hosts using musl libc, because musl only
exposes u_char if _GNU_SOURCE is defined.

Signed-off-by: Yureka Lilian <yuka@...a.dev>
---
 drivers/accessibility/speakup/utils.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
index 4bf2ee8ac..4ce9a12f7 100644
--- a/drivers/accessibility/speakup/utils.h
+++ b/drivers/accessibility/speakup/utils.h
@@ -54,7 +54,7 @@ static inline int oops(const char *msg, const char *info)
 
 static inline struct st_key *hash_name(char *name)
 {
-   u_char *pn = (u_char *)name;
+   unsigned char *pn = (unsigned char *)name;
    int hash = 0;
 
    while (*pn) {
-- 
2.37.3