linux-kernel - Re: [PATCH v2 3/5] dt-bindings: regulator: Add binding schema for mt6357 regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <972ba839-2fd3-2b45-3477-0c7e3d32f149@baylibre.com>
Date:   Tue, 11 Oct 2022 11:30:58 +0200
From:   Alexandre Mergnat <amergnat@...libre.com>
To:     krzysztof.kozlowski@...aro.org
Cc:     amergnat@...libre.com, broonie@...nel.org, chen.zhong@...iatek.com,
        devicetree@...r.kernel.org, dmitry.torokhov@...il.com,
        fparent@...libre.com, krzysztof.kozlowski+dt@...aro.org,
        lee@...nel.org, lgirdwood@...il.com,
        linux-arm-kernel@...ts.infradead.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        matthias.bgg@...il.com, robh+dt@...nel.org, robh@...nel.org
Subject: Re: [PATCH v2 3/5] dt-bindings: regulator: Add binding schema for
 mt6357 regulators

Hi Krzysztof,

Thanks for your review !

 >> +
 >> +    properties:
 >> +      regulator-name:
 >> +        pattern: "^v(core|modem|pa|proc|s1)$"
 >
 > Why enforcing particular name of the regulator?

The regulator names are forced to match with the datasheet names.

I think it's a good practice to increase visibility between HW & SW.

Also, that keep consistency with other Mediatek PMIC schema.


Best regards,

Alexandre