[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221011095233.jk2vypndisz2wgn6@soft-dev3-1.localhost>
Date: Tue, 11 Oct 2022 11:52:33 +0200
From: Horatiu Vultur <horatiu.vultur@...rochip.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC: Marc Zyngier <maz@...nel.org>, Bartosz Golaszewski <brgl@...ev.pl>,
"Kent Gibson" <warthog618@...il.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Billy Tsai <billy_tsai@...eedtech.com>,
Thomas Gleixner <tglx@...utronix.de>,
Linus Walleij <linus.walleij@...aro.org>,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Chen-Yu Tsai <wenst@...omium.org>,
Claudiu Beznea <claudiu.beznea@...rochip.com>,
Samuel Holland <samuel@...lland.org>,
Rafał Miłecki <rafal@...ecki.pl>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
Phil Edworthy <phil.edworthy@...esas.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Fabien Dessenne <fabien.dessenne@...s.st.com>,
Prathamesh Shete <pshete@...dia.com>,
Basavaraj Natikar <Basavaraj.Natikar@....com>,
<linux-gpio@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
<linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-media@...r.kernel.org>, <linux-actions@...ts.infradead.org>,
<linux-aspeed@...ts.ozlabs.org>, <openbmc@...ts.ozlabs.org>,
<linux-rpi-kernel@...ts.infradead.org>,
<alsa-devel@...a-project.org>, <patches@...nsource.cirrus.com>,
<linux-mediatek@...ts.infradead.org>, <linux-mips@...r.kernel.org>,
<linux-riscv@...ts.infradead.org>, <linux-omap@...r.kernel.org>,
<linux-stm32@...md-mailman.stormreply.com>,
<linux-arm-msm@...r.kernel.org>,
<linux-renesas-soc@...r.kernel.org>,
<linux-samsung-soc@...r.kernel.org>,
Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Patrice Chotard <patrice.chotard@...s.st.com>,
Andreas Färber <afaerber@...e.de>,
Manivannan Sadhasivam <mani@...nel.org>,
Andrew Jeffery <andrew@...id.au>,
Joel Stanley <joel@....id.au>,
Florian Fainelli <f.fainelli@...il.com>,
Ray Jui <rjui@...adcom.com>,
Scott Branden <sbranden@...adcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@...adcom.com>,
Charles Keepax <ckeepax@...nsource.cirrus.com>,
Richard Fitzgerald <rf@...nsource.cirrus.com>,
Dong Aisheng <aisheng.dong@....com>,
"Fabio Estevam" <festevam@...il.com>,
Shawn Guo <shawnguo@...nel.org>, Jacky Bai <ping.bai@....com>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
"Sascha Hauer" <s.hauer@...gutronix.de>,
NXP Linux Team <linux-imx@....com>,
"Andy Shevchenko" <andy@...nel.org>,
Sean Wang <sean.wang@...nel.org>, Andrew Lunn <andrew@...n.ch>,
Gregory Clement <gregory.clement@...tlin.com>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@...il.com>,
Avi Fishman <avifishman70@...il.com>,
Tomer Maimon <tmaimon77@...il.com>,
Tali Perry <tali.perry1@...il.com>,
Patrick Venture <venture@...gle.com>,
Nancy Yuen <yuenn@...gle.com>,
Benjamin Fair <benjaminfair@...gle.com>,
"Ludovic Desroches" <ludovic.desroches@...rochip.com>,
Nicolas Ferre <nicolas.ferre@...rochip.com>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Chen-Yu Tsai <wens@...e.org>,
Paul Cercueil <paul@...pouillou.net>,
Damien Le Moal <damien.lemoal@....com>,
Tony Lindgren <tony@...mide.com>,
Haojian Zhuang <haojian.zhuang@...aro.org>,
"Maxime Coquelin" <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Michal Simek <michal.simek@...inx.com>,
"Andy Gross" <agross@...nel.org>,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
Tomasz Figa <tomasz.figa@...il.com>,
Sylwester Nawrocki <s.nawrocki@...sung.com>,
Alim Akhtar <alim.akhtar@...sung.com>,
Viresh Kumar <vireshk@...nel.org>,
Shiraz Hashim <shiraz.linux.kernel@...il.com>,
<soc@...nel.org>, Orson Zhai <orsonzhai@...il.com>,
Baolin Wang <baolin.wang@...ux.alibaba.com>,
Chunyan Zhang <zhang.lyra@...il.com>,
"Emil Renner Berthing" <kernel@...il.dk>,
Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [PATCH v2 17/36] pinctrl: ocelot: Add missed header(s)
The 10/10/2022 23:14, Andy Shevchenko wrote:
>
> Do not imply that some of the generic headers may be always included.
> Instead, include explicitly what we are direct user of.
>
> While at it, sort headers alphabetically.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
Acked-by: Horatiu Vultur <horatiu.vultur@...rochip.com>
> drivers/pinctrl/pinctrl-ocelot.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c
> index 647e91490bac..a9343c242cd5 100644
> --- a/drivers/pinctrl/pinctrl-ocelot.c
> +++ b/drivers/pinctrl/pinctrl-ocelot.c
> @@ -13,15 +13,17 @@
> #include <linux/of_device.h>
> #include <linux/of_irq.h>
> #include <linux/of_platform.h>
> -#include <linux/pinctrl/pinctrl.h>
> -#include <linux/pinctrl/pinmux.h>
> -#include <linux/pinctrl/pinconf.h>
> -#include <linux/pinctrl/pinconf-generic.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <linux/reset.h>
> #include <linux/slab.h>
>
> +#include <linux/pinctrl/consumer.h>
> +#include <linux/pinctrl/pinconf-generic.h>
> +#include <linux/pinctrl/pinconf.h>
> +#include <linux/pinctrl/pinctrl.h>
> +#include <linux/pinctrl/pinmux.h>
> +
> #include "core.h"
> #include "pinconf.h"
> #include "pinmux.h"
> --
> 2.35.1
>
--
/Horatiu
Powered by blists - more mailing lists