linux-kernel - Re: [PATCH v2] interrupt: debug for discovering frequent interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 11 Oct 2022 18:20:57 +0800
From:   kernel test robot <lkp@...el.com>
To:     Zhang Xincheng <zhangxincheng@...ontech.com>, tglx@...utronix.de
Cc:     kbuild-all@...ts.01.org, maz@...nel.org,
        wsa+renesas@...g-engineering.com, hdegoede@...hat.com,
        bigeasy@...utronix.de, mark.rutland@....com, michael@...le.cc,
        linux-kernel@...r.kernel.org,
        Zhang Xincheng <zhangxincheng@...ontech.com>
Subject: Re: [PATCH v2] interrupt: debug for discovering frequent interrupts

Hi Zhang,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/irq/core]
[also build test WARNING on linus/master v6.0 next-20221011]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Zhang-Xincheng/interrupt-debug-for-discovering-frequent-interrupts/20221011-135800
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 36de4f94197318e45ba77badb5b07274f5bc72a9
config: m68k-allyesconfig
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/70d1ccdeb3cc035e44adfd98df109d31ed9af116
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Zhang-Xincheng/interrupt-debug-for-discovering-frequent-interrupts/20221011-135800
        git checkout 70d1ccdeb3cc035e44adfd98df109d31ed9af116
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash kernel/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   kernel/irq/spurious.c:286:6: warning: no previous prototype for 'report_frequent_irq' [-Wmissing-prototypes]
     286 | void report_frequent_irq(struct irq_desc *desc, irqreturn_t action_ret)
         |      ^~~~~~~~~~~~~~~~~~~
>> kernel/irq/spurious.c:532:12: warning: no previous prototype for 'count_per_second_setup' [-Wmissing-prototypes]
     532 | int __init count_per_second_setup(char *str)
         |            ^~~~~~~~~~~~~~~~~~~~~~
>> kernel/irq/spurious.c:549:12: warning: no previous prototype for 'duration_limit_setup' [-Wmissing-prototypes]
     549 | int __init duration_limit_setup(char *str)
         |            ^~~~~~~~~~~~~~~~~~~~
>> kernel/irq/spurious.c:566:12: warning: no previous prototype for 'disable_frequent_irq_setup' [-Wmissing-prototypes]
     566 | int __init disable_frequent_irq_setup(char *str)
         |            ^~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/count_per_second_setup +532 kernel/irq/spurious.c

   530	
   531	#ifdef CONFIG_FREQUENT_IRQ_DEBUG
 > 532	int __init count_per_second_setup(char *str)
   533	{
   534		int ret;
   535	
   536		ret = kstrtouint(str, 10, &count_per_second);
   537		if (ret)
   538			return 0;
   539	
   540		printk(KERN_INFO "Interrupt limit per second: %u\n", count_per_second);
   541	
   542		return 1;
   543	}
   544	
   545	__setup("count_per_second=", count_per_second_setup);
   546	module_param(count_per_second, uint, 0644);
   547	MODULE_PARM_DESC(count_per_second, "Interrupt limit per second. (Max 0x65535)");
   548	
 > 549	int __init duration_limit_setup(char *str)
   550	{
   551		int ret;
   552	
   553		ret = kstrtouint(str, 10, &duration_limit);
   554		if (ret)
   555			return 0;
   556	
   557		printk(KERN_INFO "Duration limit: %u\n", duration_limit);
   558	
   559		return 1;
   560	}
   561	
   562	__setup("duration_limit=", duration_limit_setup);
   563	module_param(duration_limit, uint, 0644);
   564	MODULE_PARM_DESC(duration_limit, "The number of interruptions per second exceeds the duration limit of the limit. (Max 65535)");
   565	
 > 566	int __init disable_frequent_irq_setup(char *str)
   567	{
   568		int ret;
   569	
   570		ret = kstrtobool(str, &disable_frequent_irq);
   571		if (ret)
   572			return 0;
   573	
   574		if (disable_frequent_irq)
   575			printk(KERN_INFO "Disable frequent irq'\n");
   576		else
   577			printk(KERN_INFO "Don't disable frequent irq'\n");
   578	
   579		return 1;
   580	}
   581	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (279683 bytes)