linux-kernel - Re: [PATCH v1 2/3] cgroup: add cgroup_all_get_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 11 Oct 2022 09:43:17 +0800
From:   kernel test robot <lkp@...el.com>
To:     Yosry Ahmed <yosryahmed@...gle.com>, Tejun Heo <tj@...nel.org>,
        Zefan Li <lizefan.x@...edance.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Yonghong Song <yhs@...com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        Song Liu <song@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Stanislav Fomichev <sdf@...gle.com>,
        Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>
Cc:     kbuild-all@...ts.01.org, cgroups@...r.kernel.org,
        linux-kernel@...r.kernel.org, bpf@...r.kernel.org,
        Yosry Ahmed <yosryahmed@...gle.com>
Subject: Re: [PATCH v1 2/3] cgroup: add cgroup_all_get_from_[fd/file]()

Hi Yosry,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on bpf-next/master]
[also build test WARNING on linus/master next-20221010]
[cannot apply to tj-cgroup/for-next bpf/master v6.0]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/Fix-cgroup1-support-in-get-from-fd-file-interfaces/20221011-080002
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: um-i386_defconfig
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/38847864c4501bc463dedd2ffd6119185efb5d42
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Yosry-Ahmed/Fix-cgroup1-support-in-get-from-fd-file-interfaces/20221011-080002
        git checkout 38847864c4501bc463dedd2ffd6119185efb5d42
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash kernel/cgroup/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   kernel/cgroup/cgroup.c:6184: warning: Function parameter or member 'f' not described in 'cgroup_get_from_file'
>> kernel/cgroup/cgroup.c:6696: warning: expecting prototype for cgroup_get_from_fd(). Prototype was for cgroup_all_get_from_fd() instead
   kernel/cgroup/cgroup.c:6714: warning: Function parameter or member 'fd' not described in 'cgroup_get_from_fd'


vim +6696 kernel/cgroup/cgroup.c

16af439645455f kernel/cgroup.c        Tejun Heo        2015-11-20  6685  
1f3fe7ebf6136c kernel/cgroup.c        Martin KaFai Lau 2016-06-30  6686  /**
1f3fe7ebf6136c kernel/cgroup.c        Martin KaFai Lau 2016-06-30  6687   * cgroup_get_from_fd - get a cgroup pointer from a fd
38847864c4501b kernel/cgroup/cgroup.c Yosry Ahmed      2022-10-10  6688   * @fd: fd obtained by open(cgroup_dir)
1f3fe7ebf6136c kernel/cgroup.c        Martin KaFai Lau 2016-06-30  6689   *
1f3fe7ebf6136c kernel/cgroup.c        Martin KaFai Lau 2016-06-30  6690   * Find the cgroup from a fd which should be obtained
1f3fe7ebf6136c kernel/cgroup.c        Martin KaFai Lau 2016-06-30  6691   * by opening a cgroup directory.  Returns a pointer to the
1f3fe7ebf6136c kernel/cgroup.c        Martin KaFai Lau 2016-06-30  6692   * cgroup on success. ERR_PTR is returned if the cgroup
1f3fe7ebf6136c kernel/cgroup.c        Martin KaFai Lau 2016-06-30  6693   * cannot be found.
1f3fe7ebf6136c kernel/cgroup.c        Martin KaFai Lau 2016-06-30  6694   */
38847864c4501b kernel/cgroup/cgroup.c Yosry Ahmed      2022-10-10  6695  struct cgroup *cgroup_all_get_from_fd(int fd)
1f3fe7ebf6136c kernel/cgroup.c        Martin KaFai Lau 2016-06-30 @6696  {
1f3fe7ebf6136c kernel/cgroup.c        Martin KaFai Lau 2016-06-30  6697  	struct cgroup *cgrp;
1f3fe7ebf6136c kernel/cgroup.c        Martin KaFai Lau 2016-06-30  6698  	struct file *f;
1f3fe7ebf6136c kernel/cgroup.c        Martin KaFai Lau 2016-06-30  6699  
1f3fe7ebf6136c kernel/cgroup.c        Martin KaFai Lau 2016-06-30  6700  	f = fget_raw(fd);
1f3fe7ebf6136c kernel/cgroup.c        Martin KaFai Lau 2016-06-30  6701  	if (!f)
1f3fe7ebf6136c kernel/cgroup.c        Martin KaFai Lau 2016-06-30  6702  		return ERR_PTR(-EBADF);
1f3fe7ebf6136c kernel/cgroup.c        Martin KaFai Lau 2016-06-30  6703  
38847864c4501b kernel/cgroup/cgroup.c Yosry Ahmed      2022-10-10  6704  	cgrp = cgroup_all_get_from_file(f);
1f3fe7ebf6136c kernel/cgroup.c        Martin KaFai Lau 2016-06-30  6705  	fput(f);
1f3fe7ebf6136c kernel/cgroup.c        Martin KaFai Lau 2016-06-30  6706  	return cgrp;
1f3fe7ebf6136c kernel/cgroup.c        Martin KaFai Lau 2016-06-30  6707  }
38847864c4501b kernel/cgroup/cgroup.c Yosry Ahmed      2022-10-10  6708  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (41378 bytes)