linux-kernel - Re: [PATCH] Change the I2C slave address for ds4422/4424 to its correct value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <166545307700.1702218.811193663081885499.robh@kernel.org>
Date:   Mon, 10 Oct 2022 20:52:12 -0500
From:   Rob Herring <robh@...nel.org>
To:     Rajat Khandelwal <rajat.khandelwal@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org, krzysztof.kozlowski+dt@...aro.org,
        ihkose@...il.com, devicetree@...r.kernel.org,
        rajat.khandelwal@...el.com, lars@...afoo.de, jic23@...nel.org,
        linux-iio@...r.kernel.org, robh+dt@...nel.org
Subject: Re: [PATCH] Change the I2C slave address for ds4422/4424 to its correct value

On Tue, 11 Oct 2022 23:54:37 +0530, Rajat Khandelwal wrote:
> The datasheet states that the slave address for the device is 0x20
> when the pins A0 and A1 are ground. The DT binding has been using
> 0x10 as the value and I think it should be 0x20 as per datasheet.
> 
> Let me know if I am wrong about this.
> 
> Signed-off-by: Rajat Khandelwal <rajat.khandelwal@...ux.intel.com>
> ---
>  Documentation/devicetree/bindings/iio/dac/maxim,ds4424.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/iio/dac/maxim,ds4424.example.dts:22.20-26.15: Warning (i2c_bus_reg): /example-0/i2c/dac@10: I2C bus unit address format error, expected "20"

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.