linux-kernel - Re: [RFC PATCH] Remove Intel compiler support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <08db7754-ecd8-4425-875b-4f2b44497f6b@app.fastmail.com>
Date:   Tue, 11 Oct 2022 17:18:10 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Masahiro Yamada" <masahiroy@...nel.org>,
        "Linus Torvalds" <torvalds@...ux-foundation.org>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        "Ingo Molnar" <mingo@...hat.com>, "Borislav Petkov" <bp@...en8.de>,
        "Dave Hansen" <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>
Cc:     "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        linux-ia64@...r.kernel.org,
        "Nick Desaulniers" <ndesaulniers@...gle.com>,
        "Miguel Ojeda" <ojeda@...nel.org>, "Len Brown" <lenb@...nel.org>,
        "Nathan Chancellor" <nathan@...nel.org>,
        "Nick Terrell" <terrelln@...com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        "Robert Moore" <robert.moore@...el.com>,
        "Tom Rix" <trix@...hat.com>, devel@...ica.org,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev
Subject: Re: [RFC PATCH] Remove Intel compiler support

On Tue, Oct 11, 2022, at 5:18 AM, Masahiro Yamada wrote:
> include/linux/compiler-intel.h had no update in the past 3 years.
>
> We often forget about the third C compiler to build the kernel.
>
> For example, commit a0a12c3ed057 ("asm goto: eradicate CC_HAS_ASM_GOTO")
> only mentioned GCC and Clang.
>
> init/Kconfig defines CC_IS_GCC and CC_IS_CLANG but not CC_IS_ICC,
> and nobody has reported any issue.
>
> I guess the Intel Compiler support is broken, and nobody is caring
> about it.
>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
>
> I am sending this to Linus and the x86 maintainers with RFC.
> If somebody is still using ICC, please speak up!

Acked-by: Arnd Bergmann <arnd@...db.de>


I had the same thought a while back and tried to show that it as
already broken, but I never managed to actually download the compiler
at the time.

It appears that in the meantime, Intel have completely dropped their
old codebase and moved to using LLVM[1], so my guess is that with the
current releases it will behave the same as clang. It might help
to verify that this is indeed the case if you want to add that
to the changelog text.

     Arnd

[1] https://www.intel.com/content/www/us/en/developer/articles/technical/adoption-of-llvm-complete-icx.html