linux-kernel - Re: [PATCH 2/3] LSM: Fix kernel-doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5225f90f-eb9f-c3c3-c266-f1e52b29ba34@canonical.com>
Date:   Mon, 10 Oct 2022 19:07:55 -0700
From:   John Johansen <john.johansen@...onical.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     paul@...l-moore.com, jmorris@...ei.org, serge@...lyn.com,
        apparmor@...ts.ubuntu.com, linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH 2/3] LSM: Fix kernel-doc

On 10/7/22 23:34, Jiapeng Chong wrote:
> security/apparmor/lsm.c:753: warning: expecting prototype for apparmor_bprm_committed_cred(). Prototype was for apparmor_bprm_committed_creds() instead.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2338
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Acked-by: John Johansen <john.johansen@...onical.com>

I have pulled this into my tree

> ---
>   security/apparmor/lsm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
> index cc83cbf2ce20..c56afd1307c1 100644
> --- a/security/apparmor/lsm.c
> +++ b/security/apparmor/lsm.c
> @@ -746,7 +746,7 @@ static void apparmor_bprm_committing_creds(struct linux_binprm *bprm)
>   }
>   
>   /**
> - * apparmor_bprm_committed_cred - do cleanup after new creds committed
> + * apparmor_bprm_committed_creds() - do cleanup after new creds committed
>    * @bprm: binprm for the exec  (NOT NULL)
>    */
>   static void apparmor_bprm_committed_creds(struct linux_binprm *bprm)