lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Oct 2022 11:21:53 +0900 From: Daejun Park <daejun7.park@...sung.com> To: Bean Huo <beanhuo@...pp.de>, ALIM AKHTAR <alim.akhtar@...sung.com>, "avri.altman@....com" <avri.altman@....com>, "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>, "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>, "martin.petersen@...cle.com" <martin.petersen@...cle.com>, "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>, "beanhuo@...ron.com" <beanhuo@...ron.com>, "bvanassche@....org" <bvanassche@....org>, "tomas.winkler@...el.com" <tomas.winkler@...el.com>, "cang@...eaurora.org" <cang@...eaurora.org>, Daejun Park <daejun7.park@...sung.com> CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH v2 1/2] scsi: ufs: core: Remove unnecessary if statement Hi Bean Huo, I think ufs_is_valid_unit_desc_lun() is also used for wb_buf_alloc_units_show() in ufs-sysfs.c. So just removing this if-checkup will make different result when check lun value. Thanks, Daejun >From: Bean Huo <beanhuo@...ron.com> > >LUs with WB potential support are properly checked in ufshcd_wb_probe() >before calling ufshcd_read_unit_desc_param(), so remove this unnecessary >if-checkup in ufs_is_valid_unit_desc_lun() to match its function definition. > >Signed-off-by: Bean Huo <beanhuo@...ron.com> >--- > drivers/ufs/core/ufshcd-priv.h | 3 --- > 1 file changed, 3 deletions(-) > >diff --git a/drivers/ufs/core/ufshcd-priv.h b/drivers/ufs/core/ufshcd-priv.h >index f68ca33f6ac7..2457b005101a 100644 >--- a/drivers/ufs/core/ufshcd-priv.h >+++ b/drivers/ufs/core/ufshcd-priv.h >@@ -300,9 +300,6 @@ static inline bool ufs_is_valid_unit_desc_lun(struct ufs_dev_info *dev_info, > pr_err("Max General LU supported by UFS isn't initialized\n"); > return false; > } >- /* WB is available only for the logical unit from 0 to 7 */ >- if (param_offset == UNIT_DESC_PARAM_WB_BUF_ALLOC_UNITS) >- return lun < UFS_UPIU_MAX_WB_LUN_ID; > return lun == UFS_UPIU_RPMB_WLUN || (lun < dev_info->max_lu_supported); > } > >-- >2.34.1
Powered by blists - more mailing lists