Message-ID: <6846a969-028c-f499-2e15-4ae2536edaa9@microchip.com>
Date:   Wed, 12 Oct 2022 07:52:49 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <andriy.shevchenko@...ux.intel.com>, <maz@...nel.org>,
        <brgl@...ev.pl>, <warthog618@...il.com>, <mchehab@...nel.org>,
        <billy_tsai@...eedtech.com>, <tglx@...utronix.de>,
        <linus.walleij@...aro.org>, <mika.westerberg@...ux.intel.com>,
        <angelogioacchino.delregno@...labora.com>, <wenst@...omium.org>,
        <samuel@...lland.org>, <Horatiu.Vultur@...rochip.com>,
        <rafal@...ecki.pl>, <bjorn.andersson@...aro.org>,
        <dmitry.baryshkov@...aro.org>, <geert+renesas@...der.be>,
        <prabhakar.mahadev-lad.rj@...renesas.com>,
        <phil.edworthy@...esas.com>, <krzysztof.kozlowski@...aro.org>,
        <fabien.dessenne@...s.st.com>, <pshete@...dia.com>,
        <Basavaraj.Natikar@....com>, <linux-gpio@...r.kernel.org>,
        <linux-tegra@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-media@...r.kernel.org>, <linux-actions@...ts.infradead.org>,
        <linux-aspeed@...ts.ozlabs.org>, <openbmc@...ts.ozlabs.org>,
        <linux-rpi-kernel@...ts.infradead.org>,
        <alsa-devel@...a-project.org>, <patches@...nsource.cirrus.com>,
        <linux-mediatek@...ts.infradead.org>, <linux-mips@...r.kernel.org>,
        <linux-riscv@...ts.infradead.org>, <linux-omap@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-msm@...r.kernel.org>,
        <linux-renesas-soc@...r.kernel.org>,
        <linux-samsung-soc@...r.kernel.org>
CC:     <thierry.reding@...il.com>, <jonathanh@...dia.com>,
        <patrice.chotard@...s.st.com>, <afaerber@...e.de>,
        <mani@...nel.org>, <andrew@...id.au>, <joel@....id.au>,
        <f.fainelli@...il.com>, <rjui@...adcom.com>,
        <sbranden@...adcom.com>, <bcm-kernel-feedback-list@...adcom.com>,
        <ckeepax@...nsource.cirrus.com>, <rf@...nsource.cirrus.com>,
        <aisheng.dong@....com>, <festevam@...il.com>,
        <shawnguo@...nel.org>, <ping.bai@....com>, <kernel@...gutronix.de>,
        <s.hauer@...gutronix.de>, <linux-imx@....com>, <andy@...nel.org>,
        <sean.wang@...nel.org>, <andrew@...n.ch>,
        <gregory.clement@...tlin.com>, <sebastian.hesselbarth@...il.com>,
        <avifishman70@...il.com>, <tmaimon77@...il.com>,
        <tali.perry1@...il.com>, <venture@...gle.com>, <yuenn@...gle.com>,
        <benjaminfair@...gle.com>, <Ludovic.Desroches@...rochip.com>,
        <Nicolas.Ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
        <wens@...e.org>, <paul@...pouillou.net>, <damien.lemoal@....com>,
        <tony@...mide.com>, <haojian.zhuang@...aro.org>,
        <mcoquelin.stm32@...il.com>, <alexandre.torgue@...s.st.com>,
        <michal.simek@...inx.com>, <agross@...nel.org>,
        <konrad.dybcio@...ainline.org>, <tomasz.figa@...il.com>,
        <s.nawrocki@...sung.com>, <alim.akhtar@...sung.com>,
        <vireshk@...nel.org>, <shiraz.linux.kernel@...il.com>,
        <soc@...nel.org>, <orsonzhai@...il.com>,
        <baolin.wang@...ux.alibaba.com>, <zhang.lyra@...il.com>,
        <kernel@...il.dk>, <hayashi.kunihiko@...ionext.com>,
        <mhiramat@...nel.org>
Subject: Re: [PATCH v2 06/36] pinctrl: at91: Add missed header(s)

On 10.10.2022 23:14, Andy Shevchenko wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Do not imply that some of the generic headers may be always included.
> Instead, include explicitly what we are direct user of.
> 
> While at it, sort headers alphabetically.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea@...rochip.com>


> ---
>  drivers/pinctrl/pinctrl-at91-pio4.c | 10 +++++++---
>  drivers/pinctrl/pinctrl-at91.c      | 16 +++++++++-------
>  2 files changed, 16 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c
> index 82b921fd630d..e38c683aba09 100644
> --- a/drivers/pinctrl/pinctrl-at91-pio4.c
> +++ b/drivers/pinctrl/pinctrl-at91-pio4.c
> @@ -7,18 +7,22 @@
>   */
> 
>  #include <dt-bindings/pinctrl/at91.h>
> +
>  #include <linux/clk.h>
>  #include <linux/gpio/driver.h>
> +#include <linux/init.h>
>  #include <linux/interrupt.h>
>  #include <linux/io.h>
> -#include <linux/init.h>
>  #include <linux/of.h>
>  #include <linux/platform_device.h>
> -#include <linux/pinctrl/pinconf.h>
> +#include <linux/seq_file.h>
> +#include <linux/slab.h>
> +
>  #include <linux/pinctrl/pinconf-generic.h>
> +#include <linux/pinctrl/pinconf.h>
>  #include <linux/pinctrl/pinctrl.h>
>  #include <linux/pinctrl/pinmux.h>
> -#include <linux/slab.h>
> +
>  #include "core.h"
>  #include "pinconf.h"
>  #include "pinctrl-utils.h"
> diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> index 81dbffab621f..1e1813d7c550 100644
> --- a/drivers/pinctrl/pinctrl-at91.c
> +++ b/drivers/pinctrl/pinctrl-at91.c
> @@ -7,22 +7,24 @@
> 
>  #include <linux/clk.h>
>  #include <linux/err.h>
> +#include <linux/gpio/driver.h>
>  #include <linux/init.h>
> +#include <linux/interrupt.h>
> +#include <linux/io.h>
>  #include <linux/of.h>
> -#include <linux/of_device.h>
>  #include <linux/of_address.h>
> +#include <linux/of_device.h>
>  #include <linux/of_irq.h>
> +#include <linux/pm.h>
> +#include <linux/seq_file.h>
>  #include <linux/slab.h>
> -#include <linux/interrupt.h>
> -#include <linux/io.h>
> -#include <linux/gpio/driver.h>
> +
> +/* Since we request GPIOs from ourself */
> +#include <linux/pinctrl/consumer.h>
>  #include <linux/pinctrl/machine.h>
>  #include <linux/pinctrl/pinconf.h>
>  #include <linux/pinctrl/pinctrl.h>
>  #include <linux/pinctrl/pinmux.h>
> -/* Since we request GPIOs from ourself */
> -#include <linux/pinctrl/consumer.h>
> -#include <linux/pm.h>
> 
>  #include "pinctrl-at91.h"
>  #include "core.h"
> --
> 2.35.1
> 

Powered by blists - more mailing lists