linux-kernel - Re: [PATCH v6 6/6] arm64: defconfig: Add tps65219 as modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Oct 2022 10:39:18 +0200
From:   jerome Neanne <jneanne@...libre.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        lgirdwood@...il.com, broonie@...nel.org, robh+dt@...nel.org,
        nm@...com, kristo@...nel.org, dmitry.torokhov@...il.com,
        krzysztof.kozlowski+dt@...aro.org, catalin.marinas@....com,
        will@...nel.org, lee@...nel.org, tony@...mide.com, vigneshr@...com,
        bjorn.andersson@...aro.org, shawnguo@...nel.org,
        geert+renesas@...der.be, dmitry.baryshkov@...aro.org,
        marcel.ziswiler@...adex.com, vkoul@...nel.org,
        biju.das.jz@...renesas.com, arnd@...db.de, jeff@...undy.com
Cc:     afd@...com, khilman@...libre.com, narmstrong@...libre.com,
        msp@...libre.com, j-keerthy@...com, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-input@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH v6 6/6] arm64: defconfig: Add tps65219 as modules

On 11/10/2022 16:48, Krzysztof Kozlowski wrote:
> On 11/10/2022 10:05, Jerome Neanne wrote:
>> This adds defconfig option to support TPS65219 PMIC, MFD, Regulators
> 
> Do not use "This commit/patch".
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
> 
>> and power-button.
> 
> You explained what you did, which is easily visible. You did not explain
> why you are doing it.
> 
> Best regards,
> Krzysztof
> 
Thanks for pointing me to the detailed guidelines
I'm new to upstream and not well aware of all good practices.

Would below commit message be more suitable:

Add support for the TPS65219 PMIC by enabling MFD, regulator and 
power-button drivers.  All drivers enabled as modules.

Best regards
Jerome