linux-kernel - Re: [PATCH v2] xhci: tegra: USB2 pad power controls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y0aNc5KFqOmdIw/H@kroah.com>
Date:   Wed, 12 Oct 2022 11:48:35 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jim Lin <jilin@...dia.com>
Cc:     thierry.reding@...il.com, jonathanh@...dia.com,
        linux-tegra@...r.kernel.org, mathias.nyman@...el.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] xhci: tegra: USB2 pad power controls

On Wed, Oct 12, 2022 at 05:40:20PM +0800, Jim Lin wrote:
> Program USB2 pad PD controls during port connect/disconnect, port
> suspend/resume, and test mode, to reduce power consumption on
> disconnect or suspend.
> 
> Signed-off-by: Jim Lin <jilin@...dia.com>
> ---
> v2: Fix issue that wrong tegra->phys[] may be accessed on tegra124
> 
> 
>  drivers/usb/host/xhci-tegra.c | 141 +++++++++++++++++++++++++++++++++-
>  1 file changed, 139 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
> index c8af2cd2216d..316585068ab5 100644
> --- a/drivers/usb/host/xhci-tegra.c
> +++ b/drivers/usb/host/xhci-tegra.c
> @@ -2,7 +2,7 @@
>  /*
>   * NVIDIA Tegra xHCI host controller driver
>   *
> - * Copyright (c) 2014-2020, NVIDIA CORPORATION. All rights reserved.
> + * Copyright (c) 2014-2022, NVIDIA CORPORATION. All rights reserved.

I do not think you changed this properly.  Please work with your
corporate lawyers to understand how to mark copyright changes correctly.
Then resubmit just this portion of the change with a signed-off-by: by
the lawyer so that everyone understands and agrees that it has been done
properly.

Take this portion of the diff out when you resend a v3 if you wish to
get the code changes merge sooner if your lawyers take longer than you
want :)

thanks,

greg k-h