linux-kernel - [PATCH linux-next] speakup: fix comparing pointer to 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 12 Oct 2022 10:04:55 +0000
From:   xu.panda668@...il.com
To:     w.d.hubbs@...il.com
Cc:     chris@...-brannons.com, kirk@...sers.ca,
        linux-kernel@...r.kernel.org, Xu Panda <xu.panda@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: [PATCH linux-next] speakup: fix comparing pointer to 0

From: Xu Panda <xu.panda@....com.cn>

Comparing pointer to NULL is more appropriate, and we usually compare int
to 0 and judge bool directly.

Reported-by: Zeal Robot <zealci@....com.cn>
Signed-off-by: Xu Panda <xu.panda@....com.cn>
---
 drivers/accessibility/speakup/utils.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
index 4bf2ee8ac246..a1792f3734ad 100644
--- a/drivers/accessibility/speakup/utils.h
+++ b/drivers/accessibility/speakup/utils.h
@@ -36,7 +36,7 @@ static inline void open_input(const char *dir_name, const char *name)
        else
                snprintf(filename, sizeof(filename), "%s", name);
        infile = fopen(filename, "r");
-       if (infile == 0) {
+       if (infile == NULL) {
                fprintf(stderr, "can't open %s\n", filename);
                exit(1);
        }
-- 
2.15.2