linux-kernel - Re: [PATCH] mmc: sdio: fix kernel panic when remove non-standard SDIO card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Oct 2022 12:09:27 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     欧阳炜钊(Weizhao Ouyang) 
        <ouyangweizhao@...u.com>
Cc:     王大宇(John Wang) <wangdayu@...u.com>,
        Sergey Shtylyov <s.shtylyov@....ru>,
        马宏伟(Matthew Ma) <mahongwei@...u.com>,
        Pierre Ossman <drzeus@...eus.cx>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: sdio: fix kernel panic when remove non-standard SDIO card

On Wed, 12 Oct 2022 at 03:50, 欧阳炜钊(Weizhao Ouyang)
<ouyangweizhao@...u.com> wrote:
>
> 2022年10月11日 22:41, Ulf Hansson <ulf.hansson@...aro.org> wrote:
> >
> > On Tue, 27 Sept 2022 at 04:04, Weizhao Ouyang <ouyangweizhao@...u.com>
> > wrote:
> > >
> > > From: Matthew Ma <mahongwei@...u.com>
> > >
> > > SDIO tuple is only allocated for standard SDIO card, especially it
> > > causes memory corruption issues when the non-standard SDIO card has
> > > removed since the card device's reference counter does not increase for
> > > it at sdio_init_func(), but all SDIO card device reference counter has
> > > decreased at sdio_release_func().
> > >
> > > Fixes: 1a632f8cdc33 ("sdio: split up common and function CIS parsing")
> > > Signed-off-by: Matthew Ma <mahongwei@...u.com>
> > > Reviewed-by: Weizhao Ouyang <ouyangweizhao@...u.com>
> > > Reviewed-by: John Wang <wangdayu@...u.com>
> >
> > Apologize for the delay!
> >
> > Wow, that's a very old bug you fixed! However, it looks like the fixed
> > commit should be changed to 6f51be3d37df ("sdio: allow non-standard
> > SDIO cards").
>
> Thanks, I messed the tag.
>
> >
> > I tried to apply the patch, but the patch format seems to be corrupt.
> > Did you use git format-patch and did run ./scripts/checkpatch.pl on
> > it?
> >
>
> Yeah I used checkpatch.pl with strict mode to check this patch, and it
> has no obvious style problems. What's the format error you got?

ERROR: patch seems to be corrupt (line wrapped?)
#130: FILE: drivers/mmc/core/sdio_bus.c:291:
struct sdio_func *func = dev_to_sdio_func(dev);

total: 1 errors, 0 warnings, 9 lines checked

If you haven't read the submitting-patches guidelines [1], I strongly
recommend you to have a look.
For example, it explains why you should use git send-email, if you
aren't doing that already.

Kind regards
Uffe

[1]
https://www.kernel.org/doc/html/v6.0/process/submitting-patches.html