linux-kernel - Re: [PATCH v3] xhci: tegra: USB2 pad power controls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d219eb55-ebea-091e-d9b0-3881bd4525bf@nvidia.com>
Date:   Wed, 12 Oct 2022 12:43:16 +0100
From:   Jon Hunter <jonathanh@...dia.com>
To:     Greg KH <gregkh@...uxfoundation.org>, Jim Lin <jilin@...dia.com>
Cc:     thierry.reding@...il.com, linux-tegra@...r.kernel.org,
        mathias.nyman@...el.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] xhci: tegra: USB2 pad power controls


On 12/10/2022 12:18, Greg KH wrote:
> On Wed, Oct 12, 2022 at 06:25:11PM +0800, Jim Lin wrote:
>> +static inline struct tegra_xusb *hcd_to_tegra_xusb(struct usb_hcd *hcd)
>> +{
>> +	return (struct tegra_xusb *) dev_get_drvdata(hcd->self.controller);
> 
> No need for the cast (and if there was, no need for the extra space).

May be best to drop this inline function completely and call 
dev_get_drvdata() directly. I only see it used in one place.

Jon

-- 
nvpublic