linux-kernel - Re: [PATCH] fuse: always revalidate rename target dentry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJfpegsNeeuCoF8M9TuvG3YY_Tv1pgqasR5Av0xsa3jxsnJZqA@mail.gmail.com>
Date:   Wed, 12 Oct 2022 15:50:54 +0200
From:   Miklos Szeredi <miklos@...redi.hu>
To:     Jiachen Zhang <zhangjiachen.jaycee@...edance.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Zhang Tianci <zhangtianci.1997@...edance.com>
Subject: Re: [PATCH] fuse: always revalidate rename target dentry

On Wed, 28 Sept 2022 at 14:20, Jiachen Zhang
<zhangjiachen.jaycee@...edance.com> wrote:
>
> The previous commit df8629af2934 ("fuse: always revalidate if exclusive
> create") ensures that the dentries are revalidated on O_EXCL creates. This
> commit complements it by also performing revalidation for rename target
> dentries. Otherwise, a rename target file that only exists in kernel dentry
> cache but not in the filesystem may result in an EEXIST.

"...will result in EEXIST if RENAME_NOREPLACE flag is used."

Applied with the above change.

Thanks,
Miklos