linux-kernel - Re: [PATCH] ufs: core: Disable auto h8 before ssu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bee1807b7d072b221c44ac8c2ed8064939d33696.camel@gmail.com>
Date:   Wed, 12 Oct 2022 16:25:17 +0200
From:   Bean Huo <huobean@...il.com>
To:     高严凯 <gaoyankaigeren@...il.com>,
        Avri Altman <Avri.Altman@....com>
Cc:     Alim Akhtar <alim.akhtar@...sung.com>,
        Bart Van Assche <bvanassche@....org>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        Bean Huo <beanhuo@...ron.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ufs: core: Disable auto h8 before ssu

On Tue, 2022-10-11 at 19:53 +0800, 高严凯 wrote:
> Dear Avri
>   Unisoc reports resume fail on UFS(micron FS164) during
> suspend/resume test.
>   We check host inserts auto H8 enter/exit event between SSU sleep
> command and H8 enter command in runtime suspend .
>   Asfollows: SSU Sleep command --> auto H8 enter --> auto H8 exit -->
> H8 enter --> idle 2ms --> VCC off.
>   However device AQL FW can’t enter LPM within 2ms after second H8
> enter command.
>   FW already enter LPM after receive auto H8 enter command , Next
> auto
> H8 exit command will trigger FW exit from LPM, it need take over
> 10ms,
> and FW can’t enter
>   LPM again after second H8 enter command until device complete exit
> from LPM. So disable auto h8 before ssu is a reasonable solution to
> solve it.
>   Hynix also has similar request.


Hi gaoyan,

The above sequence confuses me. UFSHCI has idle time before bringing
Link into hibern8 mode, do you know what the settings are?

Also, if auto-hibern8 is supported, in this case, the host-side SW
should not send manual hibern8. If this is an issue to all UFS or
UFSHCI, we should disable manual hibern8 if auto-hibern8 is enabled. or
let customer to choose one of two.


Kind regards,
Bean