linux-kernel - Re: [RFC PATCH 1/1] crypto: af_alg - Support symmetric encryption via keyring keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6063928.z1iD19Vvxs@tauon.chronox.de>
Date:   Wed, 12 Oct 2022 17:21:21 +0200
From:   Stephan Mueller <smueller@...onox.de>
To:     Eric Biggers <ebiggers@...nel.org>,
        Frederick Lawler <fred@...udflare.com>
Cc:     herbert@...dor.apana.org.au, davem@...emloft.net, hch@....de,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        kernel-team@...udflare.com, Ondrej Mosnacek <omosnace@...hat.com>
Subject: Re: [RFC PATCH 1/1] crypto: af_alg - Support symmetric encryption via keyring keys

Am Mittwoch, 12. Oktober 2022, 16:49:56 CEST schrieb Frederick Lawler:

Hi Frederick,

> I believe I've addressed most of the feedback. Starting with we agree
> preferring key_serial_t. I changed to to use IS_REACHABLE(), and set
> ALG_SET_KEY_BY_KEY_SERIAL to 10 leaving a comment about libkcapi
> reserving values 7-9.

This reservation should not be observed. I provided patches for adding AF_ALG 
interfaces for KPP and AKCIPHER some time ago which were rejected. Libkcapi 
still contains the interface implementations but are not compiled by default. 

As the patches are rejected, their values should not be considered as 
relevant. Thus, I think your patch should not keep holes in the numbers.

Ciao
Stephan