linux-kernel - Re: [PATCH v2] wifi: ath10k: Delay the unmapping of the buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a661njo7.fsf@kernel.org>
Date:   Wed, 12 Oct 2022 18:30:48 +0300
From:   Kalle Valo <kvalo@...nel.org>
To:     Johannes Berg <johannes@...solutions.net>
Cc:     Youghandhar Chintala <quic_youghand@...cinc.com>,
        ath10k@...ts.infradead.org, linux-wireless@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>
Subject: Re: [PATCH v2] wifi: ath10k: Delay the unmapping of the buffer

Johannes Berg <johannes@...solutions.net> writes:

> On Wed, 2022-10-12 at 19:57 +0530, Youghandhar Chintala wrote:
>> 
>> @@ -418,6 +426,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
>>  		.dynamic_sar_support = false,
>>  		.hw_restart_disconnect = false,
>>  		.use_fw_tx_credits = true,
>> +		.delay_unmap_buffer = false,
>> 
>
> All the false are unnecessary and just distract from the content, imho.

In this case I actually prefer having explicitly set false (and zero),
it makes it easier to maintain the correct order and compare between
hardware values.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches