linux-kernel - Re: [PATCH] fs: udf: Optimize udf_free_in_core_inode and udf_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221012153246.pt6ju4i3cdsenbny@quack3>
Date:   Wed, 12 Oct 2022 17:32:46 +0200
From:   Jan Kara <jack@...e.cz>
To:     Li zeming <zeming@...china.com>
Cc:     jack@...e.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: udf: Optimize udf_free_in_core_inode and
 udf_find_fileset function

On Wed 12-10-22 18:42:35, Li zeming wrote:
> These two functions perform the following optimizations.
> 1. Delete the type cast of foo pointer. Void * does not need to convert
> the type.
> 2. Delete the initialization assignment of bh variable, which is
> assigned first.
> 
> Signed-off-by: Li zeming <zeming@...china.com>

Thanks for the patch. It looks good, I'll queue it into my tree once the
merge window closes.

								Honza

> ---
>  fs/udf/super.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/udf/super.c b/fs/udf/super.c
> index 4042d9739fb7..06eda8177b5f 100644
> --- a/fs/udf/super.c
> +++ b/fs/udf/super.c
> @@ -162,7 +162,7 @@ static void udf_free_in_core_inode(struct inode *inode)
>  
>  static void init_once(void *foo)
>  {
> -	struct udf_inode_info *ei = (struct udf_inode_info *)foo;
> +	struct udf_inode_info *ei = foo;
>  
>  	ei->i_data = NULL;
>  	inode_init_once(&ei->vfs_inode);
> @@ -820,7 +820,7 @@ static int udf_find_fileset(struct super_block *sb,
>  			    struct kernel_lb_addr *fileset,
>  			    struct kernel_lb_addr *root)
>  {
> -	struct buffer_head *bh = NULL;
> +	struct buffer_head *bh;
>  	uint16_t ident;
>  	int ret;
>  
> -- 
> 2.18.2
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR