linux-kernel - Re: [PATCH v14 1/3] x86/tdx: Make __tdx_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Oct 2022 08:44:04 -0700
From:   Sathyanarayanan Kuppuswamy 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        Shuah Khan <shuah@...nel.org>,
        Jonathan Corbet <corbet@....net>,
        "H . Peter Anvin" <hpa@...or.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Tony Luck <tony.luck@...el.com>,
        Kai Huang <kai.huang@...el.com>,
        Wander Lairson Costa <wander@...hat.com>,
        Isaku Yamahata <isaku.yamahata@...il.com>,
        marcelo.cerri@...onical.com, tim.gardner@...onical.com,
        khalid.elmously@...onical.com, philip.cox@...onical.com,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH v14 1/3] x86/tdx: Make __tdx_module_call() usable in
 driver module



On 10/12/22 7:27 AM, Borislav Petkov wrote:
> On Wed, Oct 12, 2022 at 06:35:56AM -0700, Sathyanarayanan Kuppuswamy wrote:
>> So we should create a new wrapper for this use case or use
> 
> Yes, you got it - a new wrapper pls.

Ok. I will add a new wrapper to get the TDREPORT. 

+/*

+ * Add a wrapper for TDG.MR.REPORT TDCALL. It is used in TDX guest

+ * driver module to get the TDREPORT.

+ */

+long tdx_mcall_get_report(void *reportdata, void *tdreport, u8 subtype)

+{

+       if (subtype || !reportdata || !tdreport)

+               return -EINVAL;

+

+       /*

+        * Generate TDREPORT using "TDG.MR.REPORT" TDCALL.

+        *

+        * Get the TDREPORT using REPORTDATA as input. Refer to

+        * section 22.3.3 TDG.MR.REPORT leaf in the TDX Module 1.0

+        * specification for detailed information.

+        */

+       return __tdx_module_call(TDX_GET_REPORT, virt_to_phys(tdreport),

+                       virt_to_phys(reportdata), subtype, 0, NULL);

+}

+EXPORT_SYMBOL_GPL(tdx_mcall_get_report);



> 
> Thx.
> 

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer