linux-kernel - Re: [PATCH v2 23/34] dt-bindings: pinctrl: qcom,sm6115-tlmm: minor style cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 12 Oct 2022 19:11:06 +0300
From:   Iskren Chernev <iskren.chernev@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Stephan Gerhold <stephan@...hold.net>,
        Shawn Guo <shawn.guo@...aro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Vinod Koul <vkoul@...nel.org>,
        krishna Lanka <quic_vamslank@...cinc.com>,
        Martin Botka <martin.botka@...ainline.org>,
        linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v2 23/34] dt-bindings: pinctrl: qcom,sm6115-tlmm: minor
 style cleanups

On Tue, Oct 11, 2022 at 8:26 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> Drop "binding" from description (and align it with other Qualcomm
> pinctrl bindings), use double quotes consistently, drop redundant
> quotes and rename file to match compatible (to match coding convention).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Acked-by: Rob Herring <robh@...nel.org>
Reviewed-by: Iskren Chernev <iskren.chernev@...il.com>

>  ...qcom,sm6115-pinctrl.yaml => qcom,sm6115-tlmm.yaml} | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>  rename Documentation/devicetree/bindings/pinctrl/{qcom,sm6115-pinctrl.yaml => qcom,sm6115-tlmm.yaml} (95%)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-tlmm.yaml
> similarity index 95%
> rename from Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml
> rename to Documentation/devicetree/bindings/pinctrl/qcom,sm6115-tlmm.yaml
> index 3f5f5229a86c..ed68c4ee032f 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm6115-tlmm.yaml
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>  %YAML 1.2
>  ---
> -$id: http://devicetree.org/schemas/pinctrl/qcom,sm6115-pinctrl.yaml#
> +$id: http://devicetree.org/schemas/pinctrl/qcom,sm6115-tlmm.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>
>  title: Qualcomm Technologies, Inc. SM6115, SM4250 TLMM block
> @@ -10,8 +10,8 @@ maintainers:
>    - Iskren Chernev <iskren.chernev@...il.com>
>
>  description:
> -  This binding describes the Top Level Mode Multiplexer block found in the
> -  SM4250/6115 platforms.
> +  Top Level Mode Multiplexer pin controller in Qualcomm SM4250 and SM6115
> +  SoCs.
>
>  properties:
>    compatible:
> @@ -36,9 +36,8 @@ properties:
>    gpio-reserved-ranges: true
>    wakeup-parent: true
>
> -#PIN CONFIGURATION NODES
>  patternProperties:
> -  '-state$':
> +  "-state$":
>      oneOf:
>        - $ref: "#/$defs/qcom-sm6115-tlmm-state"
>        - patternProperties:
> @@ -46,7 +45,7 @@ patternProperties:
>              $ref: "#/$defs/qcom-sm6115-tlmm-state"
>          additionalProperties: false
>
> -'$defs':
> +$defs:
>    qcom-sm6115-tlmm-state:
>      type: object
>      description:
> --
> 2.34.1
>