lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 12 Oct 2022 10:56:00 -0700
From:   Kevin Hilman <khilman@...libre.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        jerome Neanne <jneanne@...libre.com>, lgirdwood@...il.com,
        broonie@...nel.org, robh+dt@...nel.org, nm@...com,
        kristo@...nel.org, dmitry.torokhov@...il.com,
        krzysztof.kozlowski+dt@...aro.org, catalin.marinas@....com,
        will@...nel.org, lee@...nel.org, tony@...mide.com, vigneshr@...com,
        bjorn.andersson@...aro.org, shawnguo@...nel.org,
        geert+renesas@...der.be, dmitry.baryshkov@...aro.org,
        marcel.ziswiler@...adex.com, vkoul@...nel.org,
        biju.das.jz@...renesas.com, arnd@...db.de, jeff@...undy.com
Cc:     afd@...com, narmstrong@...libre.com, msp@...libre.com,
        j-keerthy@...com, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-input@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH v6 6/6] arm64: defconfig: Add tps65219 as modules

Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> writes:

> On 12/10/2022 04:39, jerome Neanne wrote:
>>> You explained what you did, which is easily visible. You did not explain
>>> why you are doing it.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>> Thanks for pointing me to the detailed guidelines
>> I'm new to upstream and not well aware of all good practices.
>> 
>> Would below commit message be more suitable:
>> 
>> Add support for the TPS65219 PMIC by enabling MFD, regulator and 
>> power-button drivers.  All drivers enabled as modules.
>
> This still says only what you did. I still does not explain why.

Jerome, maybe adding a bit of preamble like:

"Development boards from TI include the TPS65219 PMIC.  Add support..."

Krzysztof, I'm the first to argue for descriptive/verbose changelogs,
but IMO, this is getting a little bit nit-picky.

The series adds a new driver, DTS and defconfig patches to enable
support the new driver.  The "why" for changes to defconfig changes like
this are kind of implied/obvious, and there is lots of precedent for
changelogs of defconfig changes for simple drivers to simply say "enable
X and Y".

If my above suggesion is not enough, please make a suggestion for what
you think would qualify as an appropritate changelong that answers "why"
for a simple driver change.

Kevin




Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ