lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Oct 2022 10:57:17 -0700 From: Peilin Ye <yepeilin.cs@...il.com> To: Leon Romanovsky <leon@...nel.org> Cc: Eric Dumazet <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, David Ahern <dsahern@...nel.org>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Peilin Ye <peilin.ye@...edance.com>, Cong Wang <cong.wang@...edance.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next v3] net/sock: Introduce trace_sk_data_ready() On Wed, Oct 12, 2022 at 08:58:32AM +0300, Leon Romanovsky wrote: > > + trace_sk_data_ready(sk, __func__); > > pr_debug("Entering iscsi_target_sk_data_ready: conn: %p\n", conn); > > This can go. <...> > __func__ repetitive pattern hints that it is not best API interface. > > > > +TRACE_EVENT(sk_data_ready, > > + > > + TP_PROTO(const struct sock *sk, const char *func), > > + > > + TP_ARGS(sk, func), > > + > > + TP_STRUCT__entry( > > + __field(const void *, skaddr) > > + __field(__u16, family) > > + __field(__u16, protocol) > > + __string(func, func) > > TRACE_EVENT() is macro defined in .h file, you can safely put __func__ > instead. Thanks for the suggestions! I will update in v4. Peilin Ye
Powered by blists - more mailing lists