linux-kernel - [ammarfaizi2-block:dhowells/linux-fs/rxrpc-ringless-5 29/41] net/rxrpc/io_thread.c:52:13: warning: variable 'skb' is uninitialized when used here

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202210130229.6Vl5bCTF-lkp@intel.com>
Date:   Thu, 13 Oct 2022 02:03:22 +0800
From:   kernel test robot <lkp@...el.com>
To:     David Howells <dhowells@...hat.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Ammar Faizi <ammarfaizi2@...weeb.org>,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        linux-kernel@...r.kernel.org
Subject: [ammarfaizi2-block:dhowells/linux-fs/rxrpc-ringless-5 29/41]
 net/rxrpc/io_thread.c:52:13: warning: variable 'skb' is uninitialized when
 used here

tree:   https://github.com/ammarfaizi2/linux-block dhowells/linux-fs/rxrpc-ringless-5
head:   f35937a690b2190554dff97d58a746e7f42425ac
commit: fbc31d44d631016c74f732902f7a24d026c5ea4d [29/41] rxrpc: Push error processing off to the local endpoint I/O thread
config: arm-buildonly-randconfig-r004-20221012
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/ammarfaizi2/linux-block/commit/fbc31d44d631016c74f732902f7a24d026c5ea4d
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block dhowells/linux-fs/rxrpc-ringless-5
        git checkout fbc31d44d631016c74f732902f7a24d026c5ea4d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash net/rxrpc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> net/rxrpc/io_thread.c:52:13: warning: variable 'skb' is uninitialized when used here [-Wuninitialized]
                   kfree_skb(skb);
                             ^~~
   net/rxrpc/io_thread.c:46:21: note: initialize the variable 'skb' to silence this warning
           struct sk_buff *skb;
                              ^
                               = NULL
   1 warning generated.


vim +/skb +52 net/rxrpc/io_thread.c

    39	
    40	/*
    41	 * Handle an error received on the local endpoint.
    42	 */
    43	void rxrpc_error_report(struct sock *sk)
    44	{
    45		struct rxrpc_local *local;
    46		struct sk_buff *skb;
    47	
    48		rcu_read_lock();
    49		local = rcu_dereference_sk_user_data(sk);
    50		if (unlikely(!local)) {
    51			rcu_read_unlock();
  > 52			kfree_skb(skb);
    53			return;
    54		}
    55	
    56		while ((skb = skb_dequeue(&sk->sk_error_queue))) {
    57			skb->mark = RXRPC_SKB_MARK_ERROR;
    58			rxrpc_new_skb(skb, rxrpc_skb_received);
    59			skb_queue_tail(&local->rx_queue, skb);
    60		}
    61	
    62		rxrpc_wake_up_io_thread(local);
    63		rcu_read_unlock();
    64	}
    65	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (153741 bytes)