linux-kernel - Re: [PATCH 1/5] pstore/ram: Consolidate kfree() paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef4743f3-b1b5-8c94-a800-bcf1463040f9@igalia.com>
Date:   Wed, 12 Oct 2022 16:43:46 -0300
From:   "Guilherme G. Piccoli" <gpiccoli@...lia.com>
To:     Kees Cook <keescook@...omium.org>, linux-hardening@...r.kernel.org
Cc:     Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>,
        Paramjit Oberoi <pso@...omium.org>,
        Ard Biesheuvel <ardb@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] pstore/ram: Consolidate kfree() paths

On 11/10/2022 17:01, Kees Cook wrote:
> There's no reason to keep separate kfree() paths: either all allocations
> succeeded, or not. Everything is torn down in the case of failure, so
> adjust the callers to reflect this.
> 
> Cc: Anton Vorontsov <anton@...msg.org>
> Cc: Colin Cross <ccross@...roid.com>
> Cc: Tony Luck <tony.luck@...el.com>
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
>  fs/pstore/ram.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 

Reviewed-and-tested-by: Guilherme G. Piccoli <gpiccoli@...lia.com>

Tested by building / booting and triggering crashes with efi and ramoops
backends.
Cheers,


Guilherme