linux-kernel - Re: [PATCH -next] media: sun6i-csi: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2603792.X9hSmTKtgW@kista>
Date:   Thu, 13 Oct 2022 00:04:03 +0200
From:   Jernej Škrabec <jernej.skrabec@...il.com>
To:     yong.deng@...ewell.com, Yang Li <yang.lee@...ux.alibaba.com>
Cc:     mchehab@...nel.org, wens@...e.org, samuel@...lland.org,
        linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Yang Li <yang.lee@...ux.alibaba.com>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] media: sun6i-csi: Remove unnecessary print function dev_err()

Hi Yang,

Dne četrtek, 29. september 2022 ob 07:40:03 CEST je Yang Li napisal(a):
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2314
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

Acked-by: Jernej Skrabec <jernej.skrabec@...il.com>

Best regards,
Jernej

> ---
>  drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c index
> 8b99c17e8403..9119f5e0e05e 100644
> --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> @@ -913,7 +913,6 @@ static int sun6i_csi_resources_setup(struct
> sun6i_csi_device *csi_dev,
> 
>  	irq = platform_get_irq(platform_dev, 0);
>  	if (irq < 0) {
> -		dev_err(dev, "failed to get interrupt\n");
>  		ret = -ENXIO;
>  		goto error_clock_rate_exclusive;
>  	}
> --
> 2.20.1.7.g153144c