linux-kernel - Re: [PATCH] net/atm: fix proc_mpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202210140457.CzlopIFy-lkp@intel.com>
Date:   Fri, 14 Oct 2022 04:23:21 +0800
From:   kernel test robot <lkp@...el.com>
To:     Xiaobo Liu <cppcoffee@...il.com>, davem@...emloft.net
Cc:     kbuild-all@...ts.01.org, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Xiaobo Liu <cppcoffee@...il.com>
Subject: Re: [PATCH] net/atm: fix proc_mpc_write 1 byte less calculated

Hi Xiaobo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]
[also build test ERROR on net/master linus/master v6.0 next-20221013]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Xiaobo-Liu/net-atm-fix-proc_mpc_write-1-byte-less-calculated/20221013-232130
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 0326074ff4652329f2a1a9c8685104576bd8d131
config: openrisc-randconfig-r035-20221012
compiler: or1k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/a873bf31a6f0de49f99feab479736ec2555de73b
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Xiaobo-Liu/net-atm-fix-proc_mpc_write-1-byte-less-calculated/20221013-232130
        git checkout a873bf31a6f0de49f99feab479736ec2555de73b
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=openrisc SHELL=/bin/bash net/atm/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   net/atm/mpoa_proc.c: In function 'proc_mpc_write':
>> net/atm/mpoa_proc.c:229:33: error: expected ';' before 'break'
     229 |                         len += 1
         |                                 ^
         |                                 ;
     230 |                         break;
         |                         ~~~~~    


vim +229 net/atm/mpoa_proc.c

   205	
   206	static ssize_t proc_mpc_write(struct file *file, const char __user *buff,
   207				      size_t nbytes, loff_t *ppos)
   208	{
   209		char *page, *p;
   210		unsigned int len;
   211	
   212		if (nbytes == 0)
   213			return 0;
   214	
   215		if (nbytes >= PAGE_SIZE)
   216			nbytes = PAGE_SIZE-1;
   217	
   218		page = (char *)__get_free_page(GFP_KERNEL);
   219		if (!page)
   220			return -ENOMEM;
   221	
   222		for (p = page, len = 0; len < nbytes; p++, len++) {
   223			if (get_user(*p, buff++)) {
   224				free_page((unsigned long)page);
   225				return -EFAULT;
   226			}
   227	
   228			if (*p == '\0' || *p == '\n') {
 > 229				len += 1
   230				break;
   231			}
   232		}
   233	
   234		*p = '\0';
   235	
   236		if (!parse_qos(page))
   237			printk("mpoa: proc_mpc_write: could not parse '%s'\n", page);
   238	
   239		free_page((unsigned long)page);
   240	
   241		return len;
   242	}
   243	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (181320 bytes)