linux-kernel - Re: [PATCH] rtc: mpfs: Use devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d78b5ac-ee87-102d-f234-c9a51d53d111@microchip.com>
Date:   Thu, 13 Oct 2022 21:34:25 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <alexandre.belloni@...tlin.com>, <a.zummo@...ertech.it>,
        <christophe.jaillet@...adoo.fr>, <Daire.McNamara@...rochip.com>,
        <Conor.Dooley@...rochip.com>
CC:     <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
        <linux-riscv@...ts.infradead.org>, <linux-rtc@...r.kernel.org>
Subject: Re: [PATCH] rtc: mpfs: Use devm_clk_get_enabled() helper

On 13/10/2022 22:32, Alexandre Belloni wrote:
> On Wed, 24 Aug 2022 10:18:25 +0200, Christophe JAILLET wrote:
>> The devm_clk_get_enabled() helper:
>>    - calls devm_clk_get()
>>    - calls clk_prepare_enable() and registers what is needed in order to
>>      call clk_disable_unprepare() when needed, as a managed resource.
>>
>> This simplifies the code, the error handling paths and avoid the need of
>> a dedicated function used with devm_add_action_or_reset().
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/1] rtc: mpfs: Use devm_clk_get_enabled() helper
>       commit: 24fb316155a5f6ba278a8b110c60e67b79900356
> 
> Best regards,
> 

While this is on my mind, making the rtc's ahb clock critical came
up in previous discussion about this patch. A fix for that was applied
to v6.0.

Thanks,
Conor.