linux-kernel - [PATCH] ACPI: acpi_pcc.c: Fix unintentional integer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20221013054947.1355884-1-pmanank200502@gmail.com>
Date:   Thu, 13 Oct 2022 11:19:48 +0530
From:   pmanank200502@...il.com
To:     rafael@...nel.org
Cc:     lenb@...nel.org, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Manank Patel <pmanank200502@...il.com>
Subject: [PATCH] ACPI: acpi_pcc.c: Fix unintentional integer overflow

From: Manank Patel <pmanank200502@...il.com>

Fixed unintentional u32 overflow by casting it to u64 before multiplication.

Signed-off-by: Manank Patel <pmanank200502@...il.com>
---
 drivers/acpi/acpi_pcc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/acpi_pcc.c b/drivers/acpi/acpi_pcc.c
index ee4ce5ba1fb2..b929d2e5c622 100644
--- a/drivers/acpi/acpi_pcc.c
+++ b/drivers/acpi/acpi_pcc.c
@@ -112,7 +112,7 @@ acpi_pcc_address_space_handler(u32 function, acpi_physical_address addr,
 		 * processor could be much slower to reply. So add an arbitrary
 		 * amount of wait on top of Nominal.
 		 */
-		usecs_lat = PCC_CMD_WAIT_RETRIES_NUM * data->pcc_chan->latency;
+		usecs_lat = PCC_CMD_WAIT_RETRIES_NUM * ((u64) data->pcc_chan->latency);
 		ret = wait_for_completion_timeout(&data->done,
 						  usecs_to_jiffies(usecs_lat));
 		if (ret == 0) {
-- 
2.38.0