linux-kernel - Re: [PATCH AUTOSEL 4.14 11/13] staging: rtl8192u: Fix return type of ieee80211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y0en/E9XgB8Wyirr@kroah.com>
Date:   Thu, 13 Oct 2022 07:54:04 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Nathan Huckleberry <nhuck@...gle.com>, llvm@...ts.linux.dev,
        Dan Carpenter <error27@...il.com>,
        Nathan Chancellor <nathan@...nel.org>, ndesaulniers@...gle.com,
        ztong0001@...il.com, dave@...olabs.net,
        linux-staging@...ts.linux.dev
Subject: Re: [PATCH AUTOSEL 4.14 11/13] staging: rtl8192u: Fix return type of
 ieee80211_xmit

On Wed, Oct 12, 2022 at 08:27:10PM -0400, Sasha Levin wrote:
> From: Nathan Huckleberry <nhuck@...gle.com>
> 
> [ Upstream commit 2851349ac351010a2649e0ff86a1e3d68fe5d683 ]
> 
> The ndo_start_xmit field in net_device_ops is expected to be of type
> netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev).
> 
> The mismatched return type breaks forward edge kCFI since the underlying
> function definition does not match the function hook definition.

Again, not needed in any stable branches, thanks.

greg k-h