linux-kernel - Re: [PATCH AUTOSEL 5.4 06/27] staging: rtl8712: Fix return type for implementation of ndo_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y0eoWDmylWzZjcNA@kroah.com>
Date:   Thu, 13 Oct 2022 07:55:36 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        GUO Zihua <guozihua@...wei.com>, Larry.Finger@...inger.net,
        florian.c.schilhabel@...glemail.com, fmdefrancesco@...il.com,
        skumark1902@...il.com, asif.kgauri@...il.com,
        linux-staging@...ts.linux.dev
Subject: Re: [PATCH AUTOSEL 5.4 06/27] staging: rtl8712: Fix return type for
 implementation of ndo_start_xmit

On Wed, Oct 12, 2022 at 08:24:38PM -0400, Sasha Levin wrote:
> From: GUO Zihua <guozihua@...wei.com>
> 
> [ Upstream commit 307d343620e1fc7a6a2b7a1cdadb705532c9b6a5 ]
> 
> CFI (Control Flow Integrity) is a safety feature allowing the system to
> detect and react should a potential control flow hijacking occurs. In
> particular, the Forward-Edge CFI protects indirect function calls by
> ensuring the prototype of function that is actually called matches the
> definition of the function hook.
> 
> Since Linux now supports CFI, it will be a good idea to fix mismatched
> return type for implementation of hooks. Otherwise this would get
> cought out by CFI and cause a panic.

And another that should be dropped from all stable branches, thanks.

greg k-h