linux-kernel - RE: [PATCH v7 2/4] mmc: sdhci-tegra: Add support to program MC stream ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM5PR12MB2406405CE44A7606B5A28203B7259@DM5PR12MB2406.namprd12.prod.outlook.com>
Date:   Thu, 13 Oct 2022 06:33:27 +0000
From:   Prathamesh Shete <pshete@...dia.com>
To:     Ulf Hansson <ulf.hansson@...aro.org>
CC:     "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Aniruddha Tvs Rao <anrao@...dia.com>,
        Suresh Mangipudi <smangipudi@...dia.com>,
        Krishna Yarlagadda <kyarlagadda@...dia.com>
Subject: RE: [PATCH v7 2/4] mmc: sdhci-tegra: Add support to program MC stream
 ID

Hi Ulf,

>> In that case, perhaps we can add a "depends on IOMMU_API" in the Kconfig
>> instead? Or is the tegra driver used on platforms where IOMMU_API could be
>> unset?
Yes it can/will work with IOMMU disabled so its not recommended to add a "depends on" condition in Kconfig.

Thanks
Prathamesh

> -----Original Message-----
> From: Ulf Hansson <ulf.hansson@...aro.org>
> Sent: Tuesday, October 11, 2022 6:04 PM
> To: Prathamesh Shete <pshete@...dia.com>
> Cc: adrian.hunter@...el.com; thierry.reding@...il.com; Jonathan Hunter
> <jonathanh@...dia.com>; p.zabel@...gutronix.de; linux-
> mmc@...r.kernel.org; linux-tegra@...r.kernel.org; linux-
> kernel@...r.kernel.org; Aniruddha Tvs Rao <anrao@...dia.com>; Suresh
> Mangipudi <smangipudi@...dia.com>; Krishna Yarlagadda
> <kyarlagadda@...dia.com>
> Subject: Re: [PATCH v7 2/4] mmc: sdhci-tegra: Add support to program MC
> stream ID
> 
> External email: Use caution opening links or attachments
> 
> 
> On Tue, 11 Oct 2022 at 13:44, Prathamesh Shete <pshete@...dia.com> wrote:
> >
> > Hi Ulf
> >
> > The initial patches were without the #ifdef. #ifdef is being added as per review
> comments and kernel robot errors.
> > Following error was detected by kernel robot
> > >>
> > All errors (new ones prefixed by >>):
> >
> >    drivers/mmc/host/sdhci-tegra.c: In function 'sdhci_tegra_probe':
> > >> drivers/mmc/host/sdhci-tegra.c:1794:54: error: 'struct iommu_fwspec' has
> no member named 'ids'
> >     1794 |                         tegra_host->streamid = fwspec->ids[0] & 0xffff;
> >          |                                                      ^~
> >
> >
> > vim +1794 drivers/mmc/host/sdhci-tegra.c
> > >>
> > Adrian also pointed out this issue so to address these issues #ifdef
> > was added
> 
> I see!
> 
> In that case, perhaps we can add a "depends on IOMMU_API" in the Kconfig
> instead? Or is the tegra driver used on platforms where IOMMU_API could be
> unset?
> 
> [...]
> 
> Kind regards
> Uffe