linux-kernel - Re: [PATCH v4 1/2] dt-bindings: it6505: add properties to restrict output bandwidth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y0fxCVUtlkB4XHIq@pendragon.ideasonboard.com>
Date:   Thu, 13 Oct 2022 14:05:45 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     allen <allen.chen@....com.tw>
Cc:     Pin-yen Lin <treapking@...omium.org>,
        Jau-Chih Tseng <Jau-Chih.Tseng@....com.tw>,
        Kenneth Hung <Kenneth.Hung@....com.tw>,
        Hermes Wu <Hermes.Wu@....com.tw>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Robert Foss <robert.foss@...aro.org>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        "open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: it6505: add properties to restrict
 output bandwidth

Hi Allen,

Thank you for the patch.

On Thu, Oct 13, 2022 at 06:51:13PM +0800, allen wrote:
> From: allen chen <allen.chen@....com.tw>
> 
> Add properties to restrict dp output data-lanes and clock.
> 
> Signed-off-by: Pin-Yen Lin <treapking@...omium.org>
> Signed-off-by: Allen Chen <allen.chen@....com.tw>
> ---
>  .../bindings/display/bridge/ite,it6505.yaml   | 43 +++++++++++++++++++
>  1 file changed, 43 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> index 833d11b2303a7..f2c3d1d10359e 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> @@ -52,10 +52,51 @@ properties:
>      maxItems: 1
>      description: extcon specifier for the Power Delivery
>  
> +  data-lanes:
> +    oneOf:
> +      - minItems: 1
> +        maxItems: 1
> +        uniqueItems: true
> +        items:
> +          enum:
> +            - 0
> +            - 1
> +        description: For one lane operation.
> +
> +      - minItems: 2
> +        maxItems: 2
> +        uniqueItems: true
> +        items:
> +          enum:
> +            - 0
> +            - 1
> +        description: For two lanes operation.
> +
> +      - minItems: 4
> +        maxItems: 4
> +        uniqueItems: true
> +        items:
> +          enum:
> +            - 0
> +            - 1
> +            - 2
> +            - 3
> +        description: For four lanes operation.

The data lanes should be in the output endpoint. If there's no output
port, one should be added.

> +
>    port:
>      $ref: /schemas/graph.yaml#/properties/port
>      description: A port node pointing to DPI host port node
>  
> +    properties:
> +      endpoint:
> +        $ref: /schemas/graph.yaml#/$defs/endpoint-base
> +
> +        properties:
> +          link-frequencies:
> +            minItems: 1
> +            maxItems: 1
> +            description: Allowed max link frequencies in Hz.
> +
>  required:
>    - compatible
>    - ovdd-supply
> @@ -84,10 +125,12 @@ examples:
>              pwr18-supply = <&it6505_pp18_reg>;
>              reset-gpios = <&pio 179 1>;
>              extcon = <&usbc_extcon>;
> +            data-lanes = <0 1>;
>  
>              port {
>                  it6505_in: endpoint {
>                      remote-endpoint = <&dpi_out>;
> +                    link-frequencies = /bits/ 64 <150000000>;
>                  };
>              };
>          };

-- 
Regards,

Laurent Pinchart