linux-kernel - Re: [PATCH] ASoC: Add Richtek RT5512 Speaker Amp Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <166565993196.4194034.3763255376639766451.robh@kernel.org>
Date:   Thu, 13 Oct 2022 06:22:44 -0500
From:   Rob Herring <robh@...nel.org>
To:     Jeff Chang <richtek.jeff.chang@...il.com>
Cc:     linux-kernel@...r.kernel.org, Jeff <jeff_chang@...htek.com>,
        devicetree@...r.kernel.org, alsa-devel@...a-project.org,
        tiwai@...e.com, broonie@...nel.org, lgirdwood@...il.com,
        robh+dt@...nel.org, jeff_chang@...thek.com,
        krzysztof.kozlowski+dt@...aro.org, perex@...ex.cz
Subject: Re: [PATCH] ASoC: Add Richtek RT5512 Speaker Amp Driver

On Thu, 13 Oct 2022 16:06:43 +0800, Jeff Chang wrote:
> From: Jeff <jeff_chang@...htek.com>
> 
> The RT5512 is a boosted class-D amplifier with V/I sensing.
> A built-in DC-DC step-up converter is used to provide efficient power for
> class-D amplifier with multi-level class-H operation. The digital audio
> interface supports I2S, left-justified, right-justified and TDM format for
> audio in with a data out used for chip information like voltage sense and
> current sense, which are able to be monitored via DATAO pin through proper
> register setting.
> 
> Signed-off-by: SHIH CHIA CHANG <jeff_chang@...htek.com>
> ---
>  .../bindings/sound/richtek,rt5512.yaml        |  50 +
>  sound/soc/codecs/Kconfig                      |  10 +
>  sound/soc/codecs/Makefile                     |   2 +
>  sound/soc/codecs/rt5512.c                     | 860 ++++++++++++++++++
>  4 files changed, 922 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/richtek,rt5512.yaml
>  create mode 100644 sound/soc/codecs/rt5512.c
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/sound/richtek,rt5512.example.dtb:0:0: /example-0/i2c/rt5512@5c: failed to match any schema with compatible: ['richtek,rt5512']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.