linux-kernel - Re: [PATCH] KVM: selftests: Fix number of pages for memory slot in memslot_modification_stress

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166566092380.1304242.1787049894105591539.b4-ty@kernel.org>
Date:   Thu, 13 Oct 2022 12:35:31 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     kvmarm@...ts.linux.dev, Gavin Shan <gshan@...hat.com>
Cc:     oliver.upton@...ux.dev, linux-kernel@...r.kernel.org,
        ajones@...tanamicro.com, kvm@...r.kernel.org, seanjc@...gle.com,
        kvmarm@...ts.cs.columbia.edu, dmatlack@...gle.com,
        pbonzini@...hat.com, venkateshs@...omium.org, peterx@...hat.com,
        shan.gavin@...il.com, shuah@...nel.org
Subject: Re: [PATCH] KVM: selftests: Fix number of pages for memory slot in memslot_modification_stress_test

On Thu, 13 Oct 2022 14:30:20 +0800, Gavin Shan wrote:
> It's required by vm_userspace_mem_region_add() that memory size
> should be aligned to host page size. However, one guest page is
> provided by memslot_modification_stress_test. It triggers failure
> in the scenario of 64KB-page-size-host and 4KB-page-size-guest,
> as the following messages indicate.
> 
>  # ./memslot_modification_stress_test
>  Testing guest mode: PA-bits:40,  VA-bits:48,  4K pages
>  guest physical test memory: [0xffbfff0000, 0xffffff0000)
>  Finished creating vCPUs
>  Started all vCPUs
>  ==== Test Assertion Failure ====
>    lib/kvm_util.c:824: vm_adjust_num_guest_pages(vm->mode, npages) == npages
>    pid=5712 tid=5712 errno=0 - Success
>       1	0x0000000000404eeb: vm_userspace_mem_region_add at kvm_util.c:822
>       2	0x0000000000401a5b: add_remove_memslot at memslot_modification_stress_test.c:82
>       3	 (inlined by) run_test at memslot_modification_stress_test.c:110
>       4	0x0000000000402417: for_each_guest_mode at guest_modes.c:100
>       5	0x00000000004016a7: main at memslot_modification_stress_test.c:187
>       6	0x0000ffffb8cd4383: ?? ??:0
>       7	0x0000000000401827: _start at :?
>    Number of guest pages is not compatible with the host. Try npages=16
> 
> [...]

Applied to fixes, thanks!

[1/1] KVM: selftests: Fix number of pages for memory slot in memslot_modification_stress_test
      commit: 05c2224d4b049406b0545a10be05280ff4b8ba0a

Cheers,

	M.
-- 
Without deviation from the norm, progress is not possible.