linux-kernel - Re: [PATCH 1/2] memory: renesas-rpc-if: Clear HS bit during hardware initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y0f9/9mcYpXG8Irf@shikoro>
Date:   Thu, 13 Oct 2022 14:01:03 +0200
From:   Wolfram Sang <wsa+renesas@...g-engineering.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Sergei Shtylyov <sergei.shtylyov@...il.com>,
        linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Cong Dang <cong.dang.xn@...esas.com>,
        Hai Pham <hai.pham.ud@...esas.com>
Subject: Re: [PATCH 1/2] memory: renesas-rpc-if: Clear HS bit during hardware
 initialization

On Wed, Oct 12, 2022 at 04:01:51PM +0200, Geert Uytterhoeven wrote:
> From: Cong Dang <cong.dang.xn@...esas.com>
> 
> According to the datasheet, HS bit should be specified to 1 when using
> DMA transfer. As DMA transfer is not supported, it should be cleared to
> 0.
> 
> Previously, the driver relied on the HS bit being cleared by prior
> firmware but this is not always the case.
> 
> Fix this by ensuring the bit is cleared during hardware initialization.
> 
> Fixes: ca7d8b980b67f133 ("memory: add Renesas RPC-IF driver")
> Signed-off-by: Cong Dang <cong.dang.xn@...esas.com>
> Signed-off-by: Hai Pham <hai.pham.ud@...esas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Reviewed-by: Wolfram Sang <wsa+renesas@...g-engineering.com>


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)