linux-kernel - Re: [PATCH 1/1] tty: n_gsm: make n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y0gLN5b4TH43NhtZ@kroah.com>
Date:   Thu, 13 Oct 2022 14:57:27 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     "Starke, Daniel" <daniel.starke@...mens.com>
Cc:     "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "jirislaby@...nel.org" <jirislaby@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] tty: n_gsm: make n_gsm line number configurable

On Thu, Oct 13, 2022 at 11:09:02AM +0000, Starke, Daniel wrote:
> > > --- a/include/uapi/linux/gsmmux.h
> > > +++ b/include/uapi/linux/gsmmux.h
> > > @@ -19,7 +19,9 @@ struct gsm_config
> > >  	unsigned int mtu;
> > >  	unsigned int k;
> > >  	unsigned int i;
> > > -	unsigned int unused[8];		/* Padding for expansion without
> > > +	unsigned short numValid;
> > > +	unsigned short num;
> > 
> > This would never work anyway (hint "short" is not a valid uapi data
> > type...)
> 
> I am surprised about this as gsm_netconfig already uses unsigned short.

How does netconfig pass data to/from userspace?  Through ioctls or
netlink?

thanks,

greg k-h