lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202210130909.EADyU1zS-lkp@intel.com>
Date:   Thu, 13 Oct 2022 21:47:54 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jason Gunthorpe <jgg@...dia.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Nicolin Chen <nicolinc@...dia.com>
Subject: [jgunthorpe:vfio_iommufd 8/20]
 drivers/iommu/iommufd/vfio_compat.c:246:13: warning: variable 'rc' set but
 not used

tree:   https://github.com/jgunthorpe/linux vfio_iommufd
head:   f44b706a4413f17e50f20999964b38d11ef84d98
commit: 8fa4c87cf7d714863f798449c6da7593231bb38b [8/20] iommufd: vfio container FD ioctl compatibility
config: s390-allmodconfig
compiler: s390-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/jgunthorpe/linux/commit/8fa4c87cf7d714863f798449c6da7593231bb38b
        git remote add jgunthorpe https://github.com/jgunthorpe/linux
        git fetch --no-tags jgunthorpe vfio_iommufd
        git checkout 8fa4c87cf7d714863f798449c6da7593231bb38b
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/iommu/iommufd/vfio_compat.c: In function 'iommufd_vfio_set_iommu':
>> drivers/iommu/iommufd/vfio_compat.c:246:13: warning: variable 'rc' set but not used [-Wunused-but-set-variable]
     246 |         int rc = 0;
         |             ^~


vim +/rc +246 drivers/iommu/iommufd/vfio_compat.c

   242	
   243	static int iommufd_vfio_set_iommu(struct iommufd_ctx *ictx, unsigned long type)
   244	{
   245		struct iommufd_ioas *ioas = NULL;
 > 246		int rc = 0;
   247	
   248		if (type != VFIO_TYPE1_IOMMU && type != VFIO_TYPE1v2_IOMMU)
   249			return -EINVAL;
   250	
   251		/* VFIO fails the set_iommu if there is no group */
   252		ioas = get_compat_ioas(ictx);
   253		if (IS_ERR(ioas))
   254			return PTR_ERR(ioas);
   255		if (type == VFIO_TYPE1_IOMMU)
   256			rc = iopt_disable_large_pages(&ioas->iopt);
   257		iommufd_put_object(&ioas->obj);
   258		return 0;
   259	}
   260	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (119688 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ