linux-kernel - Re: [PATCH v2 16/19] crypto: x86 - print CPU optimized loaded messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Oct 2022 21:48:19 +0800
From:   kernel test robot <lkp@...el.com>
To:     Robert Elliott <elliott@....com>, herbert@...dor.apana.org.au,
        davem@...emloft.net, tim.c.chen@...ux.intel.com,
        ap420073@...il.com, ardb@...nel.org, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Robert Elliott <elliott@....com>
Subject: Re: [PATCH v2 16/19] crypto: x86 - print CPU optimized loaded
 messages

Hi Robert,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on herbert-cryptodev-2.6/master]
[also build test WARNING on herbert-crypto-2.6/master linus/master next-20221012]
[cannot apply to v6.0]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Robert-Elliott/crypto-tcrypt-test-crc32/20221013-065919
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: x86_64-randconfig-m001
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

smatch warnings:
arch/x86/crypto/serpent_avx2_glue.c:113 serpent_avx2_init() warn: inconsistent indenting
arch/x86/crypto/serpent_avx2_glue.c:115 serpent_avx2_init() warn: ignoring unreachable code.
arch/x86/crypto/aegis128-aesni-glue.c:280 crypto_aegis128_aesni_module_init() warn: inconsistent indenting
arch/x86/crypto/aegis128-aesni-glue.c:282 crypto_aegis128_aesni_module_init() warn: ignoring unreachable code.
arch/x86/crypto/sm4_aesni_avx_glue.c:466 sm4_init() warn: inconsistent indenting
arch/x86/crypto/sm4_aesni_avx_glue.c:468 sm4_init() warn: ignoring unreachable code.

vim +113 arch/x86/crypto/serpent_avx2_glue.c

56d76c96a9f3e3 Jussi Kivilinna 2013-04-13  107  
f16a005cde3b1f Randy Dunlap    2022-03-16  108  static int __init serpent_avx2_init(void)
56d76c96a9f3e3 Jussi Kivilinna 2013-04-13  109  {
534ff06e39292b Ingo Molnar     2015-04-28  110  	const char *feature_name;
15a63fd12ab4d5 Robert Elliott  2022-10-12  111  	int ret;
56d76c96a9f3e3 Jussi Kivilinna 2013-04-13  112  
385e7cb709ad4a Robert Elliott  2022-10-12 @113  		return -ENODEV;
385e7cb709ad4a Robert Elliott  2022-10-12  114  
abcfdfe07de75f Borislav Petkov 2016-04-04 @115  	if (!boot_cpu_has(X86_FEATURE_AVX2) || !boot_cpu_has(X86_FEATURE_OSXSAVE)) {
b54b4bbbf5e931 Ingo Molnar     2015-05-22  116  		pr_info("AVX2 instructions are not detected.\n");
b54b4bbbf5e931 Ingo Molnar     2015-05-22  117  		return -ENODEV;
b54b4bbbf5e931 Ingo Molnar     2015-05-22  118  	}
d91cab78133d33 Dave Hansen     2015-09-02  119  	if (!cpu_has_xfeatures(XFEATURE_MASK_SSE | XFEATURE_MASK_YMM,
d91cab78133d33 Dave Hansen     2015-09-02  120  				&feature_name)) {
534ff06e39292b Ingo Molnar     2015-04-28  121  		pr_info("CPU feature '%s' is not supported.\n", feature_name);
56d76c96a9f3e3 Jussi Kivilinna 2013-04-13  122  		return -ENODEV;
56d76c96a9f3e3 Jussi Kivilinna 2013-04-13  123  	}
56d76c96a9f3e3 Jussi Kivilinna 2013-04-13  124  
15a63fd12ab4d5 Robert Elliott  2022-10-12  125  	ret = simd_register_skciphers_compat(serpent_algs,
e16bf974b3d965 Eric Biggers    2018-02-19  126  					      ARRAY_SIZE(serpent_algs),
e16bf974b3d965 Eric Biggers    2018-02-19  127  					      serpent_simd_algs);
15a63fd12ab4d5 Robert Elliott  2022-10-12  128  	if (!ret)
15a63fd12ab4d5 Robert Elliott  2022-10-12  129  		pr_info("CPU-optimized crypto module loaded\n");
15a63fd12ab4d5 Robert Elliott  2022-10-12  130  	return ret;
56d76c96a9f3e3 Jussi Kivilinna 2013-04-13  131  }
56d76c96a9f3e3 Jussi Kivilinna 2013-04-13  132  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (122604 bytes)